GWicke has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60291
Change subject: Fix JSHint warnings in TemplateHandler
......................................................................
Fix JSHint warnings in TemplateHandler
This is mostly a small step towards eliminating the global pollution in
defines by importing TagTk etc constructors explicitly.
Change-Id: I8661e81942dd86490d5591313e91ba3f1e8605e8
---
M js/lib/ext.core.TemplateHandler.js
1 file changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid
refs/changes/91/60291/1
diff --git a/js/lib/ext.core.TemplateHandler.js
b/js/lib/ext.core.TemplateHandler.js
index 7abdf0e..197cc68 100644
--- a/js/lib/ext.core.TemplateHandler.js
+++ b/js/lib/ext.core.TemplateHandler.js
@@ -19,7 +19,12 @@
api = require('./mediawiki.ApiRequest.js'),
PreprocessorRequest = api.PreprocessorRequest,
Util = require('./mediawiki.Util.js').Util,
- DOMUtils = require('./mediawiki.DOMUtils.js').DOMUtils;
+ DOMUtils = require('./mediawiki.DOMUtils.js').DOMUtils,
+ // define some constructor shortcuts
+ KV = defines.KV,
+ TagTk = defines.TagTk,
+ SelfclosingTagTk = defines.SelfclosingTagTk,
+ EndTagTk = defines.EndTagTk;
function TemplateHandler ( manager, options ) {
this.register( manager );
@@ -55,7 +60,7 @@
// magic word variables can be mistaken for templates
var translatedMagicWordKVs =
this.checkForMagicWordVariable(token.attribs[0].k);
if (translatedMagicWordKVs) {
- var metaToken = new SelfclosingTagTk('meta',
+ var metaToken = new defines.SelfclosingTagTk('meta',
translatedMagicWordKVs,
Util.clone(token.dataAttribs));
cb({ tokens: [metaToken] });
@@ -290,7 +295,7 @@
target = resolvedTgt.target;
if ( resolvedTgt.isPF ) {
- var pfAttribs = new Params( attribs );
+ var pfAttribs = new defines.Params( attribs );
pfAttribs[0] = new KV( resolvedTgt.pfArg, [] );
env.dp( 'entering prefix', target, state.token );
var newCB;
@@ -534,7 +539,7 @@
// Ignore comments in template transclusion mode
var newChunk = [];
for (i = 0, n = chunk.length; i < n; i++) {
- if (chunk[i].constructor !== CommentTk) {
+ if (chunk[i].constructor !== defines.CommentTk) {
newChunk.push(chunk[i]);
}
}
@@ -626,7 +631,9 @@
//env.dp( 'requestQueue: ', env.requestQueue );
if ( env.requestQueue[text] === undefined ) {
env.tp( 'Note: Starting new request for ' + text );
- env.requestQueue[text] = new processor( env, title,
text );
+ // fool JSHint to see a capital-case constructor
+ var JSHintFoolingProcessor = processor;
+ env.requestQueue[text] = new JSHintFoolingProcessor(
env, title, text );
}
// append request, process in document order
env.requestQueue[text].listeners( 'src' ).push( cb );
--
To view, visit https://gerrit.wikimedia.org/r/60291
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8661e81942dd86490d5591313e91ba3f1e8605e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
