jenkins-bot has submitted this change and it was merged.
Change subject: (bug 47268) lang:parseFormattedNumber should return a number,
not a string
......................................................................
(bug 47268) lang:parseFormattedNumber should return a number, not a string
The documentation, and the expectation of users, is that
lang:parseFormattedNumber() should actually return a number, not a
string.
Bug: 47268
Change-Id: Ieabddd0d9192f1fd8ef7e890d5d6268be9636f38
---
M engines/LuaCommon/lualib/mw.language.lua
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/engines/LuaCommon/lualib/mw.language.lua
b/engines/LuaCommon/lualib/mw.language.lua
index 69a6cf7..cc19db9 100644
--- a/engines/LuaCommon/lualib/mw.language.lua
+++ b/engines/LuaCommon/lualib/mw.language.lua
@@ -68,7 +68,6 @@
caseFold = 1,
formatNum = 1,
formatDate = 1,
- parseFormattedNumber = 1,
formatDuration = 1,
getDurationIntervals = 1,
convertPlural = 2,
@@ -96,6 +95,15 @@
return rtl
end
+ -- Fix semantics
+ function lang:parseFormattedNumber( ... )
+ checkSelf( self, 'parseFormattedNumber' )
+ if select( '#', ... ) < 1 then
+ error( "too few arguments to
mw.language:parseFormattedNumber", 2 )
+ end
+ return tonumber( php.parseFormattedNumber( self.code, ... ) )
+ end
+
-- Alias
lang.plural = lang.convertPlural
--
To view, visit https://gerrit.wikimedia.org/r/59364
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieabddd0d9192f1fd8ef7e890d5d6268be9636f38
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
