[MediaWiki-commits] [Gerrit] ensure /var/lib/wikibugs dir exists (home dir for user) - change (operations/puppet)

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged.

Change subject: ensure /var/lib/wikibugs dir exists (home dir for user)
......................................................................


ensure /var/lib/wikibugs dir exists (home dir for user)

PS2: fix quoting (quote resource titles and file modes,
     single quotes if no variables, double quotes if vars)
Change-Id: Ia23806e77f4cdbf12ed41c4d9f29449094a8817c
---
M manifests/misc/wikibugs.pp
1 file changed, 15 insertions(+), 10 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/manifests/misc/wikibugs.pp b/manifests/misc/wikibugs.pp
index 30f3e4c..9741379 100644
--- a/manifests/misc/wikibugs.pp
+++ b/manifests/misc/wikibugs.pp
@@ -21,31 +21,36 @@
        # default one. Values are hardcoded in the Wikibugs perl script
        $ircecho_logbase = '/var/lib/wikibugs/logs'
        $ircecho_logs = {
-               "${ircecho_logbase}/wikimedia-labs.log"           => 
"#wikimedia-labs",
-               "${ircecho_logbase}/wikimedia-mobile.log"         => 
"#wikimedia-mobile",
-               "${ircecho_logbase}/wikimedia-dev.log"            => 
"#wikimedia-dev",
+               "${ircecho_logbase}/wikimedia-labs.log"           => 
'#wikimedia-labs',
+               "${ircecho_logbase}/wikimedia-mobile.log"         => 
'#wikimedia-mobile',
+               "${ircecho_logbase}/wikimedia-dev.log"            => 
'#wikimedia-dev',
        }
 
-       $ircecho_nick = "wikibugs"
+       $ircecho_nick = 'wikibugs'
        $ircecho_server = 'chat.freenode.net'
 
        include misc::ircecho
        include misc::irc::wikibugs::packages
 
-       systemuser { wikibugs: name => 'wikibugs' }
+       systemuser { 'wikibugs': name => 'wikibugs' }
 
        file {
-               "/var/lib/wikibugs/log":
+               '/var/lib/wikibugs':
                        ensure => directory,
                        owner  => wikibugs,
                        group => wikidev,
-                       mode  => 0775,
+                       mode  => '0755';
+               '/var/lib/wikibugs/log':
+                       ensure => directory,
+                       owner  => wikibugs,
+                       group => wikidev,
+                       mode  => '0775',
                        require => User['wikibugs'];
        }
 
-       git::clone { "wikibugs" :
-               directory => "/var/lib/wikibugs/bin",
-               origin => 
"https://gerrit.wikimedia.org/r/p/wikimedia/bugzilla/wikibugs.git";,
+       git::clone { 'wikibugs' :
+               directory => '/var/lib/wikibugs/bin',
+               origin => 
'https://gerrit.wikimedia.org/r/p/wikimedia/bugzilla/wikibugs.git',
                owner => wikibugs,
                group => wikidev,
                require => User['wikibugs'];

-- 
To view, visit https://gerrit.wikimedia.org/r/60324
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia23806e77f4cdbf12ed41c4d9f29449094a8817c
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Demon <ch...@wikimedia.org>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits