jenkins-bot has submitted this change and it was merged. Change subject: SiteNotice html fail ......................................................................
SiteNotice html fail generating bad html. Sigh. Change-Id: I98ec8e8cff62f28dae08f449bf6e2ceb174ba15f --- M includes/skins/MinervaTemplate.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: MaxSem: Verified; Looks good to me, approved Mwalker: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/includes/skins/MinervaTemplate.php b/includes/skins/MinervaTemplate.php index f430175..883a5e1 100644 --- a/includes/skins/MinervaTemplate.php +++ b/includes/skins/MinervaTemplate.php @@ -27,7 +27,7 @@ $banners .= $this->data['notice']; } if ( $wgMFEnableSiteNotice ) { - $banners .= '<div id="siteNotice"><div>'; + $banners .= '<div id="siteNotice"></div>'; } $this->set( 'banners', $banners ); } -- To view, visit https://gerrit.wikimedia.org/r/60609 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98ec8e8cff62f28dae08f449bf6e2ceb174ba15f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com> Gerrit-Reviewer: Mwalker <mwal...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits