Hoo man has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/60760


Change subject: Fix underscores in titles in GetEntities
......................................................................

Fix underscores in titles in GetEntities

We don't store underscores like MW does. Like in
SpecialItemByTitle.

Change-Id: Ie1c0bb1ba3d84825d4b25d5e560ef3fe7bc6e6c6
---
M repo/includes/api/GetEntities.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/60/60760/1

diff --git a/repo/includes/api/GetEntities.php 
b/repo/includes/api/GetEntities.php
index b68a83f..13cc524 100644
--- a/repo/includes/api/GetEntities.php
+++ b/repo/includes/api/GetEntities.php
@@ -57,7 +57,8 @@
 
                                for ( $k = 0; $k < $max; $k++ ) {
                                        $siteId = $params['sites'][$idxSites++ 
% $numSites];
-                                       $title = Utils::trimToNFC( 
$params['titles'][$idxTitles++ % $numTitles] );
+                                       // We don't use underscores for storing 
titles
+                                       $title = str_replace( '_', ' ', 
Utils::trimToNFC( $params['titles'][$idxTitles++ % $numTitles] ) );
 
                                        $id = 
StoreFactory::getStore()->newSiteLinkCache()->getItemIdForLink( $siteId, $title 
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/60760
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1c0bb1ba3d84825d4b25d5e560ef3fe7bc6e6c6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to