jenkins-bot has submitted this change and it was merged. Change subject: Add stronger warnings against --all in production. ......................................................................
Add stronger warnings against --all in production. Change-Id: Ia386c7ee7f71adb755a174d236698e2a26c71525 --- M maintenance/dump_redis.php 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Ori.livneh: Looks good to me, approved jenkins-bot: Verified diff --git a/maintenance/dump_redis.php b/maintenance/dump_redis.php index fd58f08..b241881 100755 --- a/maintenance/dump_redis.php +++ b/maintenance/dump_redis.php @@ -6,6 +6,9 @@ * * It may result in a large amount of information in production. * + * Further, --all should not be used in production, since it does + * a linear scan of the keyspace. + * * @author Ori Livneh <[email protected]> * @author Matthew Flaschen <[email protected]> */ @@ -20,7 +23,7 @@ class DumpRedisCategorySync extends Maintenance { public function __construct() { parent::__construct(); - $this->addOption( 'all', 'Dump all keys with the prefix; can show keys from old naming schemes and other wikis (e.g. a different language), but can perform poorly in large Redis databases. Will not include category name', false, false ); + $this->addOption( 'all', 'Dump all keys with the prefix; can show keys from old naming schemes and other wikis (e.g. a different language). Will perform poorly in large Redis databases, so should not be used in production. Will not include category name', false, false ); $this->mDescription = 'Dump Redis data used for RedisCategorySync'; } -- To view, visit https://gerrit.wikimedia.org/r/60756 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia386c7ee7f71adb755a174d236698e2a26c71525 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/GettingStarted Gerrit-Branch: master Gerrit-Owner: Mattflaschen <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: Swalling <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
