Spage has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60787
Change subject: Better test for isGettingStarted()
......................................................................
Better test for isGettingStarted()
Don't confuse seeing the GettingStarted page with isWelcomeCreation when
we don't present it to all newly-created users get it. Instead check for the
ext.gettingstarted.accountcreation module loaded in that circumstance.
Bug: 47590
Change-Id: Iaff9f7226aa77b0e8b8abb8c32b549f64cc42d8a
---
M resources/ext.gettingstarted.openTask.js
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted
refs/changes/87/60787/1
diff --git a/resources/ext.gettingstarted.openTask.js
b/resources/ext.gettingstarted.openTask.js
index 4f19966..a73b800 100644
--- a/resources/ext.gettingstarted.openTask.js
+++ b/resources/ext.gettingstarted.openTask.js
@@ -53,8 +53,12 @@
* @return {boolean} True if user is on GettingStarted page.
*/
function isGettingStarted () {
- return cfg.wgIsWelcomeCreation ||
- cfg.wgCanonicalSpecialPageName === 'GettingStarted' ||
+ // If the user just created an account, then
wgCanonicalSpecialPageName
+ // is still "Userlogin" even if we show Special:GettingStarted
and alter
+ // browser history state, so check for the module we load in
that
+ // circumstance.
+ return cfg.wgCanonicalSpecialPageName === 'GettingStarted' ||
+ mw.loader.getState(
'ext.gettingstarted.accountcreation' ) === 'ready' ||
cfg.wgTitle.indexOf( 'E3 Test Onboarding' ) !== -1;
}
--
To view, visit https://gerrit.wikimedia.org/r/60787
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaff9f7226aa77b0e8b8abb8c32b549f64cc42d8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
