Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60789
Change subject: Adding help button to flyout. Fixing ID name per conventions.
......................................................................
Adding help button to flyout. Fixing ID name per conventions.
Change-Id: Id7243ba8e8599e1413203f951e96b73e2a6ceb9c
---
M modules/overlay/ext.echo.overlay.css
M modules/overlay/ext.echo.overlay.js
2 files changed, 31 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/89/60789/1
diff --git a/modules/overlay/ext.echo.overlay.css
b/modules/overlay/ext.echo.overlay.css
index 4c5af35..8fd69a5 100644
--- a/modules/overlay/ext.echo.overlay.css
+++ b/modules/overlay/ext.echo.overlay.css
@@ -65,6 +65,25 @@
font-weight: bold;
position: relative;
}
+#mw-echo-overlay-title-text {
+ display: inline-block;
+}
+#mw-echo-moreinfo-link {
+ display: inline-block;
+ margin: 0px 2px -2px 4px;
+ height: 13px;
+ width: 13px;
+ /* @embed */
+ background-image: url(Help.png);
+ background-repeat: no-repeat;
+ background-position: 0 0;
+ filter: alpha(opacity=50);
+ opacity: 0.5;
+}
+#mw-echo-moreinfo-link:hover {
+ filter: alpha(opacity=100);
+ opacity: 1.0;
+}
#mw-echo-overlay-footer {
padding: 0px;
diff --git a/modules/overlay/ext.echo.overlay.js
b/modules/overlay/ext.echo.overlay.js
index e57566e..76049c7 100644
--- a/modules/overlay/ext.echo.overlay.js
+++ b/modules/overlay/ext.echo.overlay.js
@@ -113,7 +113,7 @@
count = result.query.notifications.count;
mw.echo.overlay.updateCount( count );
// Reset header to 'Notifications'
-
$( '#echo-overlay-title-text').text( mw.msg( 'echo-overlay-title' ) );
+
$( '#mw-echo-overlay-title-text').text( mw.msg( 'echo-overlay-title' ) );
}
}
} );
@@ -131,11 +131,21 @@
// Add the 'mark all as read'
button to the title area
$title.append( $markReadButton
);
}
+
// Add the header to the title area
$( '<div/>' )
- .attr( 'id',
'echo-overlay-title-text' )
+ .attr( 'id',
'mw-echo-overlay-title-text' )
.text( titleText )
.appendTo( $title );
+
+ // Add help button
+ $( '<a/>' )
+ .attr( 'href', mw.config.get(
'wgEchoHelpPage' ) )
+ .attr( 'title', mw.msg(
'echo-more-info' ) )
+ .attr( 'id',
'mw-echo-moreinfo-link' )
+ .attr( 'target', '_blank' )
+ .appendTo( $title );
+
// Insert the title area into the
overlay
$title.appendTo( $overlay );
--
To view, visit https://gerrit.wikimedia.org/r/60789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7243ba8e8599e1413203f951e96b73e2a6ceb9c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
