Daniel Kinzler has submitted this change and it was merged.

Change subject: Deprecate Settings class
......................................................................


Deprecate Settings class

Change-Id: Id9313aaa58ce8d286c1904d70d8d15e6c5095b76
---
M lib/includes/Settings.php
1 file changed, 3 insertions(+), 8 deletions(-)

Approvals:
  Daniel Kinzler: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/lib/includes/Settings.php b/lib/includes/Settings.php
index b5b85f3..35de02a 100644
--- a/lib/includes/Settings.php
+++ b/lib/includes/Settings.php
@@ -1,17 +1,12 @@
 <?php
 
 namespace Wikibase;
-use MWException;
 
 /**
- * File defining the settings for the Wikibase extension.
- * More info can be found at 
https://www.mediawiki.org/wiki/Extension:Wikibase#Settings
+ * @deprecated
  *
- * NOTICE:
- * Changing one of these settings can be done by assigning to $wgWBSettings,
- * AFTER the inclusion of the extension itself.
- *
- * // TODO: have dedicated settings interfaces per extension
+ * Each component should manage its own settings,
+ * and such settings should be defined in their own configuration.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by

-- 
To view, visit https://gerrit.wikimedia.org/r/60663
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id9313aaa58ce8d286c1904d70d8d15e6c5095b76
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to