Mark Bergsma has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60814
Change subject: Remove temporary hack to ensure X-Analytics header on responses
......................................................................
Remove temporary hack to ensure X-Analytics header on responses
All objects in the cache which have X-CS but not X-Analytics
have been banned.
Change-Id: If1c01e9c2c3651bf706f608601dee57a4accddbc
---
M templates/varnish/mobile-frontend.inc.vcl.erb
1 file changed, 0 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/14/60814/1
diff --git a/templates/varnish/mobile-frontend.inc.vcl.erb
b/templates/varnish/mobile-frontend.inc.vcl.erb
index 6c16ffb..514ba81 100644
--- a/templates/varnish/mobile-frontend.inc.vcl.erb
+++ b/templates/varnish/mobile-frontend.inc.vcl.erb
@@ -658,14 +658,5 @@
if (req.url == "/favicon.ico" || req.url ~
"^/apple-touch-icon(-precomposed)?\.png$" || req.url ~
"^/w/index\.php\?title=.*:Gadget-.*&[0-9]+$") {
set resp.http.Cache-Control = "s-maxage=3600, max-age=3600";
}
-
- // FIXME: This makes sure the X-Analytics header
- // is properly set even if the request is already cached.
- // This can be removed once we are sure that all requests
- // that should have this header set but are cached without
- // it set have been invalidated.
- if ( ! resp.http.X-Analytics && req.http.X-Analytics ) {
- set resp.http.X-Analytics = req.http.X-Analytics;
- }
}
--
To view, visit https://gerrit.wikimedia.org/r/60814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If1c01e9c2c3651bf706f608601dee57a4accddbc
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mark Bergsma <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
