Nikerabbit has uploaded a new change for review. https://gerrit.wikimedia.org/r/60822
Change subject: Small comment fixes ...................................................................... Small comment fixes * translatetoolkit has been replaced with TTMServer long ago * headers per RFC to localisation team * removed no-op cache purging Change-Id: Ifcf17393d04cb995fb6105cb835deea0386c3245 --- M messagegroups/WikiPageMessageGroup.php M scripts/ttmserver-export.php M tag/TranslatablePage.php M tag/TranslateRenderJob.php 4 files changed, 8 insertions(+), 20 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/22/60822/1 diff --git a/messagegroups/WikiPageMessageGroup.php b/messagegroups/WikiPageMessageGroup.php index ad52eee..528e245 100644 --- a/messagegroups/WikiPageMessageGroup.php +++ b/messagegroups/WikiPageMessageGroup.php @@ -5,8 +5,7 @@ * @file * @author Niklas Laxström * @author Siebrand Mazeland - * @copyright Copyright © 2008-2013, Niklas Laxström, Siebrand Mazeland - * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later + * @license GPL2+ */ /** @@ -14,6 +13,7 @@ * @ingroup PageTranslation MessageGroup */ class WikiPageMessageGroup extends WikiMessageGroup { + /// @var string|Title protected $title; public function __construct( $id, $source ) { diff --git a/scripts/ttmserver-export.php b/scripts/ttmserver-export.php index 7a50811..d64f808 100644 --- a/scripts/ttmserver-export.php +++ b/scripts/ttmserver-export.php @@ -3,9 +3,7 @@ * Script to bootstrap TTMServer translation memory * * @author Niklas Laxström - * - * @copyright Copyright © 2010-2013, Niklas Laxström - * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later + * @license GPL2+ * @file */ @@ -19,7 +17,7 @@ require_once( "$IP/maintenance/Maintenance.php" ); /** - * Script to bootstrap translatetoolkit translation memory. + * Script to bootstrap TTMServer translation memory. * @since 2012-01-26 */ class TTMServerBootstrap extends Maintenance { diff --git a/tag/TranslatablePage.php b/tag/TranslatablePage.php index 1bbbac0..96ecd28 100644 --- a/tag/TranslatablePage.php +++ b/tag/TranslatablePage.php @@ -4,8 +4,7 @@ * * @file * @author Niklas Laxström - * @copyright Copyright © 2009-2013 Niklas Laxström - * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later + * @license GPL2+ */ /** @@ -135,7 +134,7 @@ break; case 'title': $this->revision = $this->getMarkedTag(); - // @todo FIXME: Needs break;? + // There is no break statement here on purpose case 'revision': $rev = Revision::newFromTitle( $this->getTitle(), $this->revision ); $this->text = $rev->getText(); @@ -588,10 +587,10 @@ } /** + * Fetch the available translation pages from database * @return Title[] */ public function getTranslationPages() { - // Fetch the available translation pages from database // Avoid replication lag issues $dbr = wfGetDB( DB_MASTER ); $prefix = $this->getTitle()->getDBkey() . '/'; @@ -612,9 +611,7 @@ // Make sure we only get translation subpages while ignoring others $codes = Language::getLanguageNames( false ); $prefix = $this->getTitle()->getText(); - /** - * @var Title $title - */ + /** @var Title $title */ foreach ( $titles as $title ) { list( $name, $code ) = TranslateUtils::figureMessage( $title->getText() ); if ( !isset( $codes[$code] ) || $name !== $prefix ) { diff --git a/tag/TranslateRenderJob.php b/tag/TranslateRenderJob.php index 5ad3cbf..134b4e4 100644 --- a/tag/TranslateRenderJob.php +++ b/tag/TranslateRenderJob.php @@ -4,7 +4,6 @@ * * @file * @author Niklas Laxström - * @copyright Copyright © 2008-2010, Niklas Laxström * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later */ @@ -61,14 +60,8 @@ // @todo FuzzyBot hack PageTranslationHooks::$allowTargetEdit = true; - - // Do the edit $article->doEdit( $text, $summary, $flags, false, $user ); - PageTranslationHooks::$allowTargetEdit = false; - - // purge cache - $page->getTranslationPercentages( true ); return true; } -- To view, visit https://gerrit.wikimedia.org/r/60822 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifcf17393d04cb995fb6105cb835deea0386c3245 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
