Daniel Kinzler has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60884
Change subject: Show correct revision of entity when viewing an old revision
......................................................................
Show correct revision of entity when viewing an old revision
Bug 44661
Change-Id: I906214322ee6dcb32d397e110d2f097f098cc253
---
M repo/includes/actions/ViewEntityAction.php
1 file changed, 1 insertion(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/84/60884/1
diff --git a/repo/includes/actions/ViewEntityAction.php
b/repo/includes/actions/ViewEntityAction.php
index b8074ca..c10199c 100644
--- a/repo/includes/actions/ViewEntityAction.php
+++ b/repo/includes/actions/ViewEntityAction.php
@@ -38,22 +38,8 @@
* @return EntityContent|null
*/
protected function getContent() {
- $queryValues = $this->getRequest()->getQueryValues();
$title = $this->getTitle();
- $revisionId = array_key_exists( 'oldid', $queryValues ) &&
is_int( $queryValues['oldid'] ) ?
- $queryValues['oldid'] : $title->getLatestRevID();
-
- if ( array_key_exists( 'diff', $queryValues ) ) {
- $diffValue = $queryValues['diff'];
-
- if ( $diffValue === 'prev' ) {
- $revisionId = $title->getPreviousRevisionID(
$revisionId );
- } else if ( $diffValue === 'next' ) {
- $revisionId = $title->getNextRevisionID(
$revisionId );
- } else {
- $revisionId = intval( $diffValue );
- }
- }
+ $revisionId = $this->getArticle()->getOldID();
$revision = \Revision::newFromTitle( $title, $revisionId );
--
To view, visit https://gerrit.wikimedia.org/r/60884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I906214322ee6dcb32d397e110d2f097f098cc253
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.22-wmf3
Gerrit-Owner: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
