Kaldari has submitted this change and it was merged.

Change subject: Get rid of wikipedia logo
......................................................................


Get rid of wikipedia logo

This was being used as the icon for the welcome and user rights notifications,
but is completely inappropriate for any site other than Wikipedia.

WMF will probably want something like this in their config:
if ( $site === 'wikipedia' ) {
        $wgEchoNotifications['welcome']['icon'] = 'w';
        $wgEchoNotifications['user-rights']['icon'] = 'w';
}

Bug: 47650
Change-Id: Idd41567ffcb468dd3d040d2a5a61d1e3f9f7f5fa
---
M Echo.php
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Kaldari: Verified; Looks good to me, approved



diff --git a/Echo.php b/Echo.php
index 9660a67..9ade890 100644
--- a/Echo.php
+++ b/Echo.php
@@ -303,7 +303,6 @@
                'group' => 'system',
                'title-message' => 'notification-new-user',
                'title-params' => array( 'agent' ),
-               'icon' => 'w',
        ),
        'edit-user-talk' => array(
                'category' => 'edit-user-talk',
@@ -399,7 +398,6 @@
                'email-body-params' => array( 'agent', 'user-rights-list', 
'email-footer' ),
                'email-body-batch-message' => 
'notification-user-rights-email-batch-body',
                'email-body-batch-params' => array( 'agent', 'user-rights-list' 
),
-               'icon' => 'w',
        ),
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/60867
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd41567ffcb468dd3d040d2a5a61d1e3f9f7f5fa
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Bsitu <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: MZMcBride <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to