Trevor Parscal has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60907
Change subject: Fix link inspector undefined madness
......................................................................
Fix link inspector undefined madness
Reuse the existing internal link annotation builder instead of using a
constructor directly, and incorrectly (it's meant to be passed an element, not
an attributes object)
Change-Id: I4cda6a9c3442cb10ebbc0844630fedba403adc91
---
M modules/ve/ui/widgets/ve.ui.MWLinkTargetInputWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/07/60907/1
diff --git a/modules/ve/ui/widgets/ve.ui.MWLinkTargetInputWidget.js
b/modules/ve/ui/widgets/ve.ui.MWLinkTargetInputWidget.js
index 956eab7..c8c77e6 100644
--- a/modules/ve/ui/widgets/ve.ui.MWLinkTargetInputWidget.js
+++ b/modules/ve/ui/widgets/ve.ui.MWLinkTargetInputWidget.js
@@ -195,7 +195,7 @@
) );
for ( i = 0, len = matchingPages.length; i < len; i++ ) {
items.push( new ve.ui.MenuItemWidget(
- new ve.dm.MWInternalLinkAnnotation( { 'title':
matchingPages[i] } ),
+ this.getInternalLinkAnnotationFromTitle(
matchingPages[i] ),
{ '$$': menu$$, 'rel': 'matchingPage', 'label':
matchingPages[i] }
) );
}
--
To view, visit https://gerrit.wikimedia.org/r/60907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cda6a9c3442cb10ebbc0844630fedba403adc91
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
