Catrope has submitted this change and it was merged.

Change subject: Clean up VisualEditor settings
......................................................................


Clean up VisualEditor settings

Remove wmgVisualEditorHide (we don't need this any more) and allow
editing for NS_MAIN and NS_USER on mediawikiwiki (this had been
over-looked in the December deployment to enwiki).

Bug: 42936
Change-Id: Iec91b30422017ce9d71bc71b2cbeb71688e0d18f
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
2 files changed, 2 insertions(+), 11 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 22e8979..eb3e743 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -2187,9 +2187,6 @@
                $wgExtraNamespaces[NS_VISUALEDITOR_TALK] = 'VisualEditor_talk';
                $wgVisualEditorNamespaces[] = NS_VISUALEDITOR;
        }
-       if ( $wmgVisualEditorHide ) {
-               $wgHiddenPrefs[] = 'visualeditor-enable';
-       }
        if ( $wmgVisualEditorDefault ) {
                $wgDefaultUserOptions['visualeditor-enable'] = 1;
        }
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 43ebc9c..7095d2e 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -10376,8 +10376,7 @@
 ),
 
 'wmgVisualEditorNamespaces' => array(
-       'default' => array( NS_MAIN, NS_USER ),
-       'mediawikiwiki' => array(), // NS_VISUALEDITOR added in 
CommonSettings.php
+       'default' => array( NS_MAIN, NS_USER ), // mediawikiwiki 
NS_VISUALEDITOR added in CommonSettings.php
 ),
 
 // For wikis that used VisualEditor before 2012-11-12
@@ -10387,14 +10386,9 @@
        'mediawikiwiki' => true,
 ),
 
-'wmgVisualEditorHide' => array(
-       'default' => false,
-       'mediawikiwiki' => true, // pre-2012-11-12 install
-),
-
 'wmgVisualEditorDefault' => array(
        'default' => false,
-       'mediawikiwiki' => true // pre-2012-11-12 install
+       'mediawikiwiki' => true // Enabled for all users
 ),
 
 'wmgUseRSSExtension' => array(

-- 
To view, visit https://gerrit.wikimedia.org/r/60911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iec91b30422017ce9d71bc71b2cbeb71688e0d18f
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to