Zfilipin has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/60992


Change subject: Do not check anything in a "given" step
......................................................................

Do not check anything in a "given" step

All checks should be done in a "then" step

Change-Id: Ife3cd0975a981dd32c21b0485e8b8a86a07a9cd7
---
M tests/acceptance/features/step_definitions/watchlist_steps.rb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/92/60992/1

diff --git a/tests/acceptance/features/step_definitions/watchlist_steps.rb 
b/tests/acceptance/features/step_definitions/watchlist_steps.rb
index 390eec0..80f6f92 100644
--- a/tests/acceptance/features/step_definitions/watchlist_steps.rb
+++ b/tests/acceptance/features/step_definitions/watchlist_steps.rb
@@ -6,7 +6,7 @@
 end
 
 Given /^I am not logged in$/ do
-  on(HomePage).login_button_element.should exist
+  # nothing to do here, user in not logged in by default
 end
 
 When /^Select the watchlist icon$/ do

-- 
To view, visit https://gerrit.wikimedia.org/r/60992
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife3cd0975a981dd32c21b0485e8b8a86a07a9cd7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to