jenkins-bot has submitted this change and it was merged.
Change subject: thanks-thanked message needs GENDER support
......................................................................
thanks-thanked message needs GENDER support
Bug: 46595
Change-Id: I7061403808d428ad244b75ebdcdb2dc900acd3bf
---
M Thanks.i18n.php
M modules/ext.thanks.thank.js
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Thanks.i18n.php b/Thanks.i18n.php
index e210aaa..47bacbb 100644
--- a/Thanks.i18n.php
+++ b/Thanks.i18n.php
@@ -13,7 +13,7 @@
$messages['en'] = array(
'thanks-desc' => 'Adds thank links to history and diff views',
'thanks-thank' => 'thank',
- 'thanks-thanked' => 'thanked',
+ 'thanks-thanked' => '{{GENDER:$1|thanked}}',
'thanks-error-undefined' => 'Thank action failed. Please try again.',
'thanks-error-invalidrevision' => 'Revision ID is not valid.',
'thanks-error-ratelimited' => "You've exceeded your rate limit. Please
wait some time and try again.",
@@ -44,7 +44,8 @@
$messages['qqq'] = array(
'thanks-desc' =>
'{{desc|name=Thanks|url=http://www.mediawiki.org/wiki/Extension:Thanks}}',
'thanks-thank' => 'Link to thank another user. This is a verb.',
- 'thanks-thanked' => 'Message that replaces the link to thank another
user after they have been thanked (Echo-thank). This is short for "the user
that created this revision has been thanked for it".',
+ 'thanks-thanked' => 'Message that replaces the link to thank another
user after they have been thanked (Echo-thank). This is short for "You thanked
the user for their edit.". Parameters:
+* $1 is the current user, for GENDER support.',
'thanks-error-undefined' => 'Error message that is displayed when the
thank action fails.
{{Identical|Please try again}}',
'thanks-error-invalidrevision' => 'Error message that is displayed when
the revision ID is not valid',
diff --git a/modules/ext.thanks.thank.js b/modules/ext.thanks.thank.js
index 1b5c7d4..ca0de55 100644
--- a/modules/ext.thanks.thank.js
+++ b/modules/ext.thanks.thank.js
@@ -16,7 +16,7 @@
'token' : mw.user.tokens.values.editToken
} )
.done( function( data ) {
- $thankLink.before( mw.msg( 'thanks-thanked' ) );
+ $thankLink.before( mw.message( 'thanks-thanked',
mw.user ).escaped() );
$thankLink.remove();
} )
.fail( function( errorCode, details ) {
--
To view, visit https://gerrit.wikimedia.org/r/60894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7061403808d428ad244b75ebdcdb2dc900acd3bf
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/Thanks
Gerrit-Branch: master
Gerrit-Owner: EBernhardson (WMF) <[email protected]>
Gerrit-Reviewer: EBernhardson (WMF) <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Matmarex <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
