Inez has uploaded a new change for review.
https://gerrit.wikimedia.org/r/61055
Change subject: (bug 47711) Fix FF specific bug
......................................................................
(bug 47711) Fix FF specific bug
Firefox fires key press events for arrow keys - but we handle them already in
keydown - so solution is to just ignore those key press in handler.
Change-Id: I1aff295a0958b75697c4d362e0d6095283f37fe8
---
M modules/ve/ce/ve.ce.Surface.js
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/55/61055/1
diff --git a/modules/ve/ce/ve.ce.Surface.js b/modules/ve/ce/ve.ce.Surface.js
index 23093f6..125a961 100644
--- a/modules/ve/ce/ve.ce.Surface.js
+++ b/modules/ve/ce/ve.ce.Surface.js
@@ -410,7 +410,9 @@
}
}
- if ( ve.ce.isShortcutKey( e ) ||
+ // FF fire keypress for arrow keys but we handle them in keydown so
let's ignore
+ if ( ve.ce.isArrowKey( e.keyCode ) ||
+ ve.ce.isShortcutKey( e ) ||
e.which === ve.Keys.DOM_VK_RETURN ||
e.which === ve.Keys.DOM_VK_BACK_SPACE ||
e.which === ve.Keys.DOM_VK_UNDEFINED ) {
--
To view, visit https://gerrit.wikimedia.org/r/61055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1aff295a0958b75697c4d362e0d6095283f37fe8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
