Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/61156
Change subject: Moving a pref override from Echo to PageTriage
......................................................................
Moving a pref override from Echo to PageTriage
Bug: 47757
Change-Id: I2a574ebe530a2bb37b85155220f14f999a639587
---
M PageTriage.hooks.php
M PageTriage.php
2 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage
refs/changes/56/61156/1
diff --git a/PageTriage.hooks.php b/PageTriage.hooks.php
index 7a46b23..b947b61 100644
--- a/PageTriage.hooks.php
+++ b/PageTriage.hooks.php
@@ -565,4 +565,19 @@
}
return true;
}
+
+ /**
+ * Handler for AddNewAccount hook
+ * @see http://www.mediawiki.org/wiki/Manual:Hooks/AddNewAccount
+ * @param $user User object that was created.
+ * @param $byEmail bool True when account was created "by email".
+ * @return bool
+ */
+ public static function onAccountCreated( $user, $byEmail ) {
+ // New users get echo preferences set that are not the default
settings for existing users.
+ // Specifically, new users are opted into email notifications
for page reviews.
+ $user->setOption( 'echo-subscriptions-email-page-review', true
);
+ $user->saveSettings();
+ return true;
+ }
}
diff --git a/PageTriage.php b/PageTriage.php
index 72bd5f6..15c0af7 100644
--- a/PageTriage.php
+++ b/PageTriage.php
@@ -96,7 +96,9 @@
'pagetriage-add-maintenance-tag',
'pagetriage-add-deletion-tag'
);
+// Set default user options
$wgDefaultUserOptions['echo-subscriptions-web-page-review'] = true;
+// This is overriden for new users in PageTriageHooks::onAccountCreated
$wgDefaultUserOptions['echo-subscriptions-email-page-review'] = false;
// End configuration variables
@@ -158,6 +160,7 @@
$wgHooks['ResourceLoaderGetConfigVars'][] =
'PageTriageHooks::onResourceLoaderGetConfigVars';
$wgHooks['BeforeCreateEchoEvent'][] =
'PageTriageHooks::onBeforeCreateEchoEvent';
$wgHooks['EchoGetDefaultNotifiedUsers'][] =
'PageTriageHooks::onEchoGetDefaultNotifiedUsers';
+$wgHooks['AddNewAccount'][] = 'PageTriageHooks::onAccountCreated';
// logging
$wgLogTypes[] = 'pagetriage-curation';
--
To view, visit https://gerrit.wikimedia.org/r/61156
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a574ebe530a2bb37b85155220f14f999a639587
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
