jenkins-bot has submitted this change and it was merged. Change subject: Use more precise type annotation for promise. ......................................................................
Use more precise type annotation for promise. Change-Id: Ia56e52a9e1717d17a09bd224254a9c35131f47ee --- M modules/ext.eventLogging.core.js 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ori.livneh: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ext.eventLogging.core.js b/modules/ext.eventLogging.core.js index 239cb32..a876e57 100644 --- a/modules/ext.eventLogging.core.js +++ b/modules/ext.eventLogging.core.js @@ -240,7 +240,7 @@ * * @method dispatch * @param {Object} data Payload to send. - * @return {jQuery.Deferred} Promise object. + * @return {jQuery.Promise} jQuery Promise object for the logging call */ dispatch: function ( data ) { var beacon = document.createElement( 'img' ), @@ -273,7 +273,7 @@ * @method logEvent * @param {String} schemaName Canonical schema name. * @param {Object} eventInstance Event instance. - * @return {jQuery.Deferred} Promise object. + * @return {jQuery.Promise} jQuery Promise object for the logging call */ logEvent: function ( schemaName, eventInstance ) { return self.dispatch( self.encapsulate( schemaName, eventInstance ) ); -- To view, visit https://gerrit.wikimedia.org/r/61170 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia56e52a9e1717d17a09bd224254a9c35131f47ee Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/EventLogging Gerrit-Branch: master Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits