Nischayn22 has uploaded a new change for review. https://gerrit.wikimedia.org/r/61249
Change subject: Use $.each() instead of for loop ...................................................................... Use $.each() instead of for loop Bug: 47771 Change-Id: I583dbb8e196b7b87137ac9de2c4747d1e99405fc --- M resources/mw.UploadWizardDetails.js 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/49/61249/1 diff --git a/resources/mw.UploadWizardDetails.js b/resources/mw.UploadWizardDetails.js index e1859bf..29cf093 100644 --- a/resources/mw.UploadWizardDetails.js +++ b/resources/mw.UploadWizardDetails.js @@ -626,11 +626,10 @@ } } ]; - for ( var mx in msgs ) { - var msg = msgs[mx]; + $.each( msgs, function( index, msg ) { var $lbl = $( 'label[for="' + msg.title + '"]' ); $lbl.text( mw.msg( msg.title, msg.counter() ) ); - } + } ); $lbl = $( '.mwe-upwiz-details-copy-metadata a', _this.$form ); $lbl.text( mw.msg( 'mwe-upwiz-copy-metadata', _this.upload.wizard.uploads.length - 1 ) ); }, -- To view, visit https://gerrit.wikimedia.org/r/61249 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I583dbb8e196b7b87137ac9de2c4747d1e99405fc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Nischayn22 <nischay...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits