Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/61342
Change subject: Update how icon is configured for corresponding Echo change
......................................................................
Update how icon is configured for corresponding Echo change
Bug: 46585
Change-Id: I84c7a92917f7a14e865a6a4bc9aff643f7cfba77
---
M GettingStarted.hooks.php
D resources/ext.gettingstarted.echo.css
2 files changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted
refs/changes/42/61342/1
diff --git a/GettingStarted.hooks.php b/GettingStarted.hooks.php
index 73851ad..5cf9f00 100644
--- a/GettingStarted.hooks.php
+++ b/GettingStarted.hooks.php
@@ -110,9 +110,14 @@
return true;
}
- public static function onBeforeCreateEchoEvent( &$notifications,
&$categories ) {
+ public static function onBeforeCreateEchoEvent( &$notifications,
&$categories, &$icons ) {
// Currently not used, but most notifications seem to include
agent as a param.
// It will allow username to be included later with just a
message change.
+
+ $icons['gettingstarted-contribute'] = array(
+ 'path' =>
'GettingStarted/resources/images/echo-gettingstarted-icon.png',
+ );
+
$defaults = array(
'category' => 'system',
'group' => 'positive',
@@ -120,7 +125,7 @@
'email-subject-params' => array( 'agent' ),
'email-body-params' => array( 'agent', 'titlelink',
'email-footer' ),
'email-body-batch-params' => array( 'agent',
'titlelink' ),
- 'icon' => 'gettingstarted',
+ 'icon' => 'gettingstarted-contribute',
);
$notifications['gettingstarted-start-editing'] = array(
diff --git a/resources/ext.gettingstarted.echo.css
b/resources/ext.gettingstarted.echo.css
deleted file mode 100644
index 187c55b..0000000
--- a/resources/ext.gettingstarted.echo.css
+++ /dev/null
@@ -1,7 +0,0 @@
-/* Loaded on every page so it is available for Echo */
-
-/* I had to add extra specificity to override the default 'none' background */
-.mw-echo-icon.mw-echo-icon-gettingstarted {
- /* @embed */
- background-image: url(images/echo-gettingstarted-icon.png);
-}
--
To view, visit https://gerrit.wikimedia.org/r/61342
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84c7a92917f7a14e865a6a4bc9aff643f7cfba77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
