jenkins-bot has submitted this change and it was merged.
Change subject: Add new $icons parameter to Echo hook:
......................................................................
Add new $icons parameter to Echo hook:
* Update doc block
* Use names that indicate the variables are passed in, not used as globals.
Bug: 46585
Change-Id: I0f15498ab1fba239bce141b178340a9d9984bedf
---
M Thanks.hooks.php
1 file changed, 8 insertions(+), 7 deletions(-)
Approvals:
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Thanks.hooks.php b/Thanks.hooks.php
index 1c280c8..c802f72 100644
--- a/Thanks.hooks.php
+++ b/Thanks.hooks.php
@@ -88,17 +88,18 @@
}
/**
- * Add extension event to $wgEchoEnabledEvents
- * @param $wgEchoEnabledEvents array a list of enabled echo events
- * @param $wgEchoEventDetails array details for echo events
- * @return bool
+ * Add Thanks events to Echo
+ *
+ * @param $notifications array of Echo notifications
+ * @param $notificationCategories array of Echo notification categories
+ * @param $icons array of icon details
*/
- public static function onBeforeCreateEchoEvent( &$wgEchoNotifications,
&$wgEchoNotificationCategories ) {
- $wgEchoNotificationCategories['edit-thank'] = array(
+ public static function onBeforeCreateEchoEvent( &$notifications,
&$notificationCategories, &$icons ) {
+ $notificationCategories['edit-thank'] = array(
'priority' => 3,
);
- $wgEchoNotifications['edit-thank'] = array(
+ $notifications['edit-thank'] = array(
'category' => 'edit-thank',
'group' => 'interactive',
'formatter-class' => 'EchoThanksFormatter',
--
To view, visit https://gerrit.wikimedia.org/r/61344
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f15498ab1fba239bce141b178340a9d9984bedf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Thanks
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
