Hashar has uploaded a new change for review.
https://gerrit.wikimedia.org/r/61424
Change subject: multiversion: headers() do not play nice on CLI
......................................................................
multiversion: headers() do not play nice on CLI
When using MWMultiversion from the CLI, we would get a 'can not modify
header information' whenever an error is emitted. That is a bit
cumbersome so just skip the headers() call whenever we are on CLI.
Change-Id: Ie32e36802c93d0430958a96bacf4a22bca4d16f8
---
M multiversion/MWMultiVersion.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config
refs/changes/24/61424/1
diff --git a/multiversion/MWMultiVersion.php b/multiversion/MWMultiVersion.php
index 13db7cb..7b9cc13 100644
--- a/multiversion/MWMultiVersion.php
+++ b/multiversion/MWMultiVersion.php
@@ -357,8 +357,8 @@
$msg = (string)$msg;
if ( PHP_SAPI !== 'cli' ) {
$msg = htmlspecialchars( $msg );
+ header( 'HTTP/1.1 500 Internal server error' );
}
- header( 'HTTP/1.1 500 Internal server error' );
echo $msg;
trigger_error( $msg, E_USER_ERROR );
exit( 1 ); // sanity
--
To view, visit https://gerrit.wikimedia.org/r/61424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie32e36802c93d0430958a96bacf4a22bca4d16f8
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
