Andrew Bogott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/61466
Change subject: Don't require group IDs to be even.
......................................................................
Don't require group IDs to be even.
For integer conservation! We were only using every other possible gid
for obsolete (and never actually useful) reasons.
Change-Id: I43e6cd6c0624e409a524abeb8a46df14f948fc67
---
M nova/OpenStackNovaUser.php
1 file changed, 0 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenStackManager
refs/changes/66/61466/1
diff --git a/nova/OpenStackNovaUser.php b/nova/OpenStackNovaUser.php
index 32725bf..deda742 100644
--- a/nova/OpenStackNovaUser.php
+++ b/nova/OpenStackNovaUser.php
@@ -399,11 +399,6 @@
}
sort( $uids, SORT_NUMERIC );
$highest = array_pop( $uids ) + 1;
- if ( $attr === 'gidnumber' && $highest
% 2 ) {
- # Ensure groups are always
even, since they'll
- # be used for namespaces as
well.
- $highest = $highest + 1;
- }
}
} else {
$auth->printDebug( "Failed to find any entries
when searching for next $attr", NONSENSITIVE );
--
To view, visit https://gerrit.wikimedia.org/r/61466
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43e6cd6c0624e409a524abeb8a46df14f948fc67
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Andrew Bogott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
