jenkins-bot has submitted this change and it was merged.
Change subject: Fixed docs
......................................................................
Fixed docs
Wrong param type.
<pre> tags quoted to avoid jsduck warning.
Change-Id: Ieb9b5527ea69c8f02a175d29c1534290f85ba032
---
M modules/ve/ui/ve.ui.Window.js
M modules/ve/ve.js
2 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ui/ve.ui.Window.js b/modules/ve/ui/ve.ui.Window.js
index 818d08d..cbc1982 100644
--- a/modules/ve/ui/ve.ui.Window.js
+++ b/modules/ve/ui/ve.ui.Window.js
@@ -297,7 +297,7 @@
* loop.
*
* @method
- * @param {boolean} action Action that caused the window to be closed
+ * @param {string} action Action that caused the window to be closed
* @emits close
*/
ve.ui.Window.prototype.close = function ( action ) {
diff --git a/modules/ve/ve.js b/modules/ve/ve.js
index 308e4cd..b07d43b 100644
--- a/modules/ve/ve.js
+++ b/modules/ve/ve.js
@@ -1009,9 +1009,9 @@
/**
* Get the actual inner HTML of a DOM node.
*
- * In most browsers, .innerHTML is broken and eats newlines in <pre>s,
see
+ * In most browsers, .innerHTML is broken and eats newlines in
`<pre>`s, see
* https://bugzilla.mozilla.org/show_bug.cgi?id=838954 . This function
detects this behavior
- * and works around it, to the extent possible. <pre>\nFoo</pre> will
become <pre>Foo</pre>
+ * and works around it, to the extent possible. `<pre>\nFoo</pre>` will
become `<pre>Foo</pre>`
* if the browser is broken, but newlines are preserved in all other
cases.
*
* @param {HTMLElement} element HTML element to get inner HTML of
@@ -1020,7 +1020,7 @@
ve.properInnerHTML = function ( element ) {
var div, $element;
if ( ve.isPreInnerHTMLBroken === undefined ) {
- // Test whether newlines in <pre> are serialized back
correctly
+ // Test whether newlines in `<pre>` are serialized back
correctly
div = document.createElement( 'div' );
div.innerHTML = '<pre>\n\n</pre>';
ve.isPreInnerHTMLBroken = div.innerHTML ===
'<pre>\n</pre>';
@@ -1030,11 +1030,11 @@
return element.innerHTML;
}
- // Workaround for bug 42469: if a <pre> starts with a newline,
that means .innerHTML will
+ // Workaround for bug 42469: if a `<pre>` starts with a
newline, that means .innerHTML will
// screw up and stringify it with one fewer newline. Work
around this by adding a newline.
// If we don't see a leading newline, we still don't know if
the original HTML was
- // <pre>Foo</pre> or <pre>\nFoo</pre> , but that's a syntactic
difference, not a semantic
- // one, and handling that is Parsoid's job.
+ // `<pre>Foo</pre>` or `<pre>\nFoo</pre>` , but that's a
syntactic difference, not a
+ // semantic one, and handling that is Parsoid's job.
$element = $( element ).clone();
$element.find( 'pre, textarea, listing' ).each( function() {
var matches;
--
To view, visit https://gerrit.wikimedia.org/r/61469
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb9b5527ea69c8f02a175d29c1534290f85ba032
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
