Kaldari has submitted this change and it was merged.
Change subject: Fully remove ext.gettingstarted.echo module
......................................................................
Fully remove ext.gettingstarted.echo module
Bug: 47839
Change-Id: I22d3f00fd4995f7ed95e02a52ba0f36a5312db59
---
M GettingStarted.hooks.php
M GettingStarted.php
2 files changed, 1 insertion(+), 9 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
Kaldari: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/GettingStarted.hooks.php b/GettingStarted.hooks.php
index 5cf9f00..9ccc367 100644
--- a/GettingStarted.hooks.php
+++ b/GettingStarted.hooks.php
@@ -34,10 +34,6 @@
public static function onBeforePageDisplay( $out, $skin ) {
$out->addModules( 'ext.gettingstarted.openTask' );
- if ( class_exists( 'EchoNotifier' ) ) {
- $out->addModules( 'ext.gettingstarted.echo' );
- }
-
return true;
}
diff --git a/GettingStarted.php b/GettingStarted.php
index 45f9bf1..7bc71a0 100644
--- a/GettingStarted.php
+++ b/GettingStarted.php
@@ -109,7 +109,7 @@
),
) + $gettingStartedModuleInfo;
-// ext.gettingstarted.openTask and ext.gettingstarted.echo (if Echo is
enabled) are every page site-wide.
+// ext.gettingstarted.openTask is every page site-wide.
$wgResourceModules[ 'ext.gettingstarted.openTask' ] = array(
'scripts' => 'ext.gettingstarted.openTask.js',
'dependencies' => array(
@@ -124,10 +124,6 @@
'messages' => array(
'red-link-title'
)
-) + $gettingStartedModuleInfo;
-
-$wgResourceModules[ 'ext.gettingstarted.echo' ] = array(
- 'styles' => 'ext.gettingstarted.echo.css'
) + $gettingStartedModuleInfo;
// This loads on both account creation and the special page, even if JS is off
--
To view, visit https://gerrit.wikimedia.org/r/61464
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22d3f00fd4995f7ed95e02a52ba0f36a5312db59
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
