Henning Snater has uploaded a new change for review.
https://gerrit.wikimedia.org/r/61551
Change subject: Adding and applying a new icon for the snak type selector
......................................................................
Adding and applying a new icon for the snak type selector
Replaces the inappropriate gear icon triggering the snak type selection
with a custom icon.
Change-Id: Ide03e6b2e2c355c7550417e961a2adbec22c5a7d
---
M lib/resources/Resources.php
M
lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.SnakTypeSelector.js
A
lib/resources/jquery.wikibase/jquery.wikibase.snakview/themes/default/images/ui-icon_snaktypeselector_72a7cf.png
A
lib/resources/jquery.wikibase/jquery.wikibase.snakview/themes/default/snakview.SnakTypeSelector.css
4 files changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/51/61551/1
diff --git a/lib/resources/Resources.php b/lib/resources/Resources.php
index 3a3986f..9091b9d 100644
--- a/lib/resources/Resources.php
+++ b/lib/resources/Resources.php
@@ -537,6 +537,9 @@
'jquery.wikibase/jquery.wikibase.snakview/snakview.variations.SomeValue.js',
'jquery.wikibase/jquery.wikibase.snakview/snakview.variations.NoValue.js',
),
+ 'styles' => array(
+
'jquery.wikibase/jquery.wikibase.snakview/themes/default/snakview.SnakTypeSelector.css',
+ ),
'dependencies' => array(
'jquery.eachchange',
'jquery.nativeEventHandler',
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.SnakTypeSelector.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.SnakTypeSelector.js
index e5dbbc5..68aadca 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.SnakTypeSelector.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.SnakTypeSelector.js
@@ -62,7 +62,8 @@
// TODO: add a title message
this.element
- .addClass( 'ui-icon ui-icon-gear ' +
this.widgetBaseClass )
+ // TODO: Add other ui states like "hover" implementing
and using .ui-state-<state> css classes
+ .addClass( 'ui-icon ui-icon-snaktypeselector ' +
this.widgetBaseClass )
.on( 'click.wb-snaktypeselector', function( event ) {
// don't show menu if selector is disabled!
// otherwise, simply toggle menu's visibility
@@ -112,7 +113,7 @@
this._menu.destroy();
$menu.remove();
- this.element.removeClass( 'ui-icon ui-icon-gear ' +
this.widgetBaseClass );
+ this.element.removeClass( 'ui-icon
ui-icon-snaktypeselector ' + this.widgetBaseClass );
// remove event listeners responsible for closing this
instance's menu:
this._unbindGlobalListenersFn();
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/themes/default/images/ui-icon_snaktypeselector_72a7cf.png
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/themes/default/images/ui-icon_snaktypeselector_72a7cf.png
new file mode 100644
index 0000000..c3e46f8
--- /dev/null
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/themes/default/images/ui-icon_snaktypeselector_72a7cf.png
Binary files differ
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/themes/default/snakview.SnakTypeSelector.css
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/themes/default/snakview.SnakTypeSelector.css
new file mode 100644
index 0000000..efeaebe
--- /dev/null
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/themes/default/snakview.SnakTypeSelector.css
@@ -0,0 +1,5 @@
+/* TODO: Add icons actually coloured like default theme, add vector theme
icons */
+
+.ui-icon-snaktypeselector {
+ background-image: url(images/ui-icon_snaktypeselector_72a7cf.png);
+}
--
To view, visit https://gerrit.wikimedia.org/r/61551
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide03e6b2e2c355c7550417e961a2adbec22c5a7d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
