Jdlrobson has submitted this change and it was merged.
Change subject: Add a comment explaining why SQL's count is not used
......................................................................
Add a comment explaining why SQL's count is not used
Change-Id: I672cc659d51c4b2eb702ebdc4d0836d90e1ab000
---
M includes/specials/SpecialUploads.php
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jdlrobson: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/includes/specials/SpecialUploads.php
b/includes/specials/SpecialUploads.php
index ba61317..bf57064 100644
--- a/includes/specials/SpecialUploads.php
+++ b/includes/specials/SpecialUploads.php
@@ -73,6 +73,7 @@
$limit = $this->getUploadCountThreshold() + 1;
$dbr->ignoreErrors( true );
+ // not using SQL's count(*) because it's more expensive with
big number of rows
$res = $dbr->select(
'image',
'img_size',
--
To view, visit https://gerrit.wikimedia.org/r/61694
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I672cc659d51c4b2eb702ebdc4d0836d90e1ab000
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
