jenkins-bot has submitted this change and it was merged.
Change subject: Adding bidi-isolation to reference numbers
......................................................................
Adding bidi-isolation to reference numbers
This is a quick-fix to support proper rendering of <sup>[1]</sup> elements
when the sentence contains a right-to-left word.
Amended: Changed from working through jQuery 'wrap' to CSS unicode-bidi.
Amended: Dos2Unix conversion to get rid of pesky hidden characters, also
corrected all of Amire80's comments.
Bug: 36032
Change-Id: If85efe5ff1e0a3c57ee2523656702db89df07145
---
M Cite.php
A modules/ext.rtlcite/ext.rtlcite.css
2 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Amire80: Looks good to me, but someone else must approve
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Cite.php b/Cite.php
index e4d7e92..b547b5b 100644
--- a/Cite.php
+++ b/Cite.php
@@ -85,6 +85,12 @@
'position' => 'bottom',
);
+/* Add RTL fix for the cite <sup> elements */
+$wgResourceModules['ext.rtlcite'] = $citeResourceTemplate + array(
+ 'styles' => 'ext.rtlcite/ext.rtlcite.css',
+ 'position' => 'bottom',
+);
+
/**
* @param $out OutputPage
* @param $sk Skin
@@ -97,6 +103,8 @@
$out->addModules( 'ext.cite' );
}
+ /* RTL support quick-fix module */
+ $out->addModules( 'ext.rtlcite' );
return true;
}
diff --git a/modules/ext.rtlcite/ext.rtlcite.css
b/modules/ext.rtlcite/ext.rtlcite.css
new file mode 100644
index 0000000..9b88d53
--- /dev/null
+++ b/modules/ext.rtlcite/ext.rtlcite.css
@@ -0,0 +1,6 @@
+/* Isolation to fix references in case of RTL words at the end of a reference
*/
+sup.reference {
+ unicode-bidi: -moz-isolate;
+ unicode-bidi: -webkit-isolate;
+ unicode-bidi: isolate;
+}
--
To view, visit https://gerrit.wikimedia.org/r/61634
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If85efe5ff1e0a3c57ee2523656702db89df07145
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il>
Gerrit-Reviewer: Kghbln <mediaw...@kghoffmeyer.de>
Gerrit-Reviewer: Platonides <platoni...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
