Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/61816
Change subject: Improvements to mediawiki_singlenode ...................................................................... Improvements to mediawiki_singlenode * Change ServerAdmin to a URL, pointing at module docs. See <http://httpd.apache.org/docs/current/mod/core.html#serveradmin>. * In erb templates, use '@varname' to refer to Puppet vars; 'varname' can clash with Ruby names. * Rename 'simplewiki.wmflabs.org' to 'mediawiki_singlenode.erb'. * Use notify / refreshonly pattern for Exec['apache_restart'] rather than 'require'. * Redirect root URL to MediaWiki main page. Change-Id: Iddae7ed1f61094e27a89b87049597f2ebd92a4e8 --- M modules/mediawiki_singlenode/manifests/init.pp R modules/mediawiki_singlenode/templates/mediawiki_singlenode.erb 2 files changed, 18 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/16/61816/1 diff --git a/modules/mediawiki_singlenode/manifests/init.pp b/modules/mediawiki_singlenode/manifests/init.pp index d4bf362..59196bf 100644 --- a/modules/mediawiki_singlenode/manifests/init.pp +++ b/modules/mediawiki_singlenode/manifests/init.pp @@ -57,7 +57,7 @@ owner => root, group => root, mode => '0644', - content => template('mediawiki_singlenode/simplewiki.wmflabs.org'), + content => template('mediawiki_singlenode/mediawiki_singlenode.erb'), } if $::labs_mediawiki_hostname { @@ -124,12 +124,17 @@ } apache_site { 'wikicontroller': - name => 'wiki', + name => 'wiki', + notify => Exec['apache_restart'], + } + + apache_module { 'rewrite': + notify => Exec['apache_restart'], } exec { 'apache_restart': - require => [ Apache_site['wikicontroller'] ], - command => '/usr/sbin/service apache2 restart', + command => '/usr/sbin/service apache2 restart', + refreshonly => true, } file { "${install_path}/cache": diff --git a/modules/mediawiki_singlenode/templates/simplewiki.wmflabs.org b/modules/mediawiki_singlenode/templates/mediawiki_singlenode.erb similarity index 69% rename from modules/mediawiki_singlenode/templates/simplewiki.wmflabs.org rename to modules/mediawiki_singlenode/templates/mediawiki_singlenode.erb index 0c9dae1..2f1cd07 100644 --- a/modules/mediawiki_singlenode/templates/simplewiki.wmflabs.org +++ b/modules/mediawiki_singlenode/templates/mediawiki_singlenode.erb @@ -1,11 +1,13 @@ <VirtualHost *:80> - ServerAdmin [email protected] + ServerAdmin "https://wikitech.wikimedia.org/wiki/Help:Single_Node_MediaWiki"; DocumentRoot /var/www + <Directory /> Options FollowSymLinks AllowOverride None </Directory> + <Directory /var/www/> Options Indexes FollowSymLinks MultiViews AllowOverride None @@ -13,12 +15,15 @@ allow from all </Directory> - <Directory <%=install_path%>/orig> + <Directory <%= @install_path %>/orig> Deny from all </Directory> - Alias /w <%=install_path%> - Alias /wiki <%=install_path%>/index.php + RewriteEngine On + RewriteRule ^/$ /w/index.php [R=301] + + Alias /wiki "<%= @install_path %>/index.php" + Alias /w "<%= @install_path %>" ErrorLog /var/log/apache2/error.log -- To view, visit https://gerrit.wikimedia.org/r/61816 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iddae7ed1f61094e27a89b87049597f2ebd92a4e8 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ori.livneh <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
