jenkins-bot has submitted this change and it was merged.
Change subject: Escape colons in definition term text
......................................................................
Escape colons in definition term text
Fixes this test case:
echo '<dl><dt>foo: bar</dt></dl>' | node parse --html2wt
;<nowiki>foo: bar</nowiki>
No change in parserTests, so need to add a test for this.
Bug: 47747
Change-Id: Ibab4c46f2c517bcd9398713e6dee3f7c0188144e
---
M js/lib/mediawiki.WikitextSerializer.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/lib/mediawiki.WikitextSerializer.js
b/js/lib/mediawiki.WikitextSerializer.js
index 8ff92bf..9347d63 100644
--- a/js/lib/mediawiki.WikitextSerializer.js
+++ b/js/lib/mediawiki.WikitextSerializer.js
@@ -155,7 +155,9 @@
WEHP.liHandler = function(liNode, state, text, opts) {
// Only bullets at the beginning of the list trigger escaping
- if (state.currLine.text === '' && opts.node === liNode.firstChild) {
+ if (liNode.nodeName === 'DT' && /:/.test(text)) {
+ return true;
+ } else if (state.currLine.text === '' && opts.node ===
liNode.firstChild) {
return text.match(/^[#\*:;]/);
} else {
return false;
--
To view, visit https://gerrit.wikimedia.org/r/61918
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibab4c46f2c517bcd9398713e6dee3f7c0188144e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
