Netbrain has uploaded a new change for review.
https://gerrit.wikimedia.org/r/61961
Change subject: Refactored due to changes in spreadsheet-js Added a redraw
timeout to highcharts as it turned out to be cpu consuming to redraw on every
valuechange event
......................................................................
Refactored due to changes in spreadsheet-js
Added a redraw timeout to highcharts as it turned out to be cpu consuming to
redraw on every valuechange event
Change-Id: If7a63982c720bf1900fad9dcd952203180f670de
---
M js/spreadsheet.bootstrap.js
M lib/spreadsheet-js
2 files changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Spreadsheet
refs/changes/61/61961/1
diff --git a/js/spreadsheet.bootstrap.js b/js/spreadsheet.bootstrap.js
index 27c5c26..01f3403 100644
--- a/js/spreadsheet.bootstrap.js
+++ b/js/spreadsheet.bootstrap.js
@@ -115,7 +115,16 @@
return function(e){
var point = c.get(e.cell.position);
try{
- point.update(e.cell.valueOf());
+ point.update(e.cell.valueOf(),false);
+ if(!c.redrawTimer){
+ c.redrawTimer =
setTimeout((function(chart){
+ return function(){
+ chart.redraw();
+
clearTimeout(chart.redrawTimer);
+ delete
chart.redrawTimer;
+ };
+ })(c),1000);
+ }
}catch(err){
alert('Error occured while updating point!');
}
@@ -217,9 +226,6 @@
name:spreadsheet.getCellValue(series.name)
});
}
- console.log(JSON.stringify(config,function(key,val){
- return key == "id" ? val.toString() : val;
- },2));
new
Highcharts.Chart(config,getOnLoadCallback(spreadsheet));
//Chart is now appended, so lets clear the interval
clearInterval(appendChartInterval);
diff --git a/lib/spreadsheet-js b/lib/spreadsheet-js
index f2716cd..e9853f5 160000
--- a/lib/spreadsheet-js
+++ b/lib/spreadsheet-js
-Subproject commit f2716cd76e9aec0f3dbd00cf3dc0687254b87e1b
+Subproject commit e9853f5fcfb0d6d204176ca54564856c52ad4047
--
To view, visit https://gerrit.wikimedia.org/r/61961
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7a63982c720bf1900fad9dcd952203180f670de
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Spreadsheet
Gerrit-Branch: master
Gerrit-Owner: Netbrain <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
