Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/62108
Change subject: add favicons for doc.wm and integration.wm ...................................................................... add favicons for doc.wm and integration.wm < mutante> hashar: i know this is really minor and random, but favicons are popular in wmf these days File does not exist: /srv/org/wikimedia/doc/favicon.ico < mutante> just noticed in error.log it's the most common 404 < hashar> we are using another favicon which is specified in the CSS < hashar> we specify https://bits.wikimedia.org/favicon/wmf.ico in the HTML :-] < TimStarling> even if you specify a shortcut icon in the HTML, /favicon.ico is still needed < TimStarling> because it will be used for non-HTML requests, like when you open an image < TimStarling> or if you view the source of a JS file Change-Id: I6c03cdc331eb39566a2cb5e481298d68564a2362 --- A modules/contint/files/apache/wmf.ico M modules/contint/manifests/website.pp 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/08/62108/1 diff --git a/modules/contint/files/apache/wmf.ico b/modules/contint/files/apache/wmf.ico new file mode 100644 index 0000000..bde61ef --- /dev/null +++ b/modules/contint/files/apache/wmf.ico Binary files differ diff --git a/modules/contint/manifests/website.pp b/modules/contint/manifests/website.pp index 58cec15..f90d4e9 100644 --- a/modules/contint/manifests/website.pp +++ b/modules/contint/manifests/website.pp @@ -24,6 +24,16 @@ owner => 'jenkins', group => 'jenkins', } + + # have a favicon, even if we also specify it in HTML + file { '/srv/org/wikmedia/integration/favicon.ico': + ensure => present, + mode => '0444' + owner => 'www-data', + group => 'www-data', + source => 'puppet:///modules/contint/apache/wmf.ico', + } + # MediaWiki code coverage file { '/srv/org/wikimedia/integration/coverage': ensure => directory, @@ -62,6 +72,16 @@ owner => 'jenkins', group => 'jenkins', } + + # have a favicon, even if we also specify it in HTML + file { '/srv/org/wikmedia/doc/favicon.ico': + ensure => present, + mode => '0444' + owner => 'www-data', + group => 'www-data', + source => 'puppet:///modules/contint/apache/wmf.ico', + } + file { '/etc/apache2/sites-available/doc.wikimedia.org': mode => '0444', owner => 'root', -- To view, visit https://gerrit.wikimedia.org/r/62108 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6c03cdc331eb39566a2cb5e481298d68564a2362 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <dz...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
