Waldir has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62157
Change subject: Minor tweaks to installer UX / UI: - add a tooltip to the
"help" links to make it clear they'll expand in place - don't use an IMG tag
for the download link; instead, use a css background to the A element, so
that there isn't an underlined space betwe
......................................................................
Minor tweaks to installer UX / UI:
- add a tooltip to the "help" links to make it clear they'll expand in place
- don't use an IMG tag for the download link;
instead, use a css background to the A element,
so that there isn't an underlined space between the link text and the image
- grammar fix to sqlite help message: replace a colon by a semicolon.
Change-Id: Iacf5ed57d983a21d87467c848823607032901cec
---
M includes/installer/Installer.i18n.php
M includes/installer/WebInstaller.php
M skins/common/config.css
3 files changed, 10 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/57/62157/1
diff --git a/includes/installer/Installer.i18n.php
b/includes/installer/Installer.i18n.php
index e216a2f..5cd210a 100644
--- a/includes/installer/Installer.i18n.php
+++ b/includes/installer/Installer.i18n.php
@@ -231,7 +231,7 @@
The directory you provide must be writable by the webserver during
installation.
-It should '''not''' be accessible via the web, this is why we're not putting
it where your PHP files are.
+It should '''not''' be accessible via the web; this is why we're not putting
it where your PHP files are.
The installer will write a <code>.htaccess</code> file along with it, but if
that fails someone can gain access to your raw database.
That includes raw user data (email addresses, hashed passwords) as well as
deleted revisions and other restricted data on the wiki.
diff --git a/includes/installer/WebInstaller.php
b/includes/installer/WebInstaller.php
index 10c7b96..ca92189 100644
--- a/includes/installer/WebInstaller.php
+++ b/includes/installer/WebInstaller.php
@@ -660,7 +660,7 @@
$html = $this->parse( $text, true );
return "<div class=\"mw-help-field-container\">\n" .
- "<span class=\"mw-help-field-hint\">" . wfMessage(
'config-help' )->escaped() .
+ "<span class=\"mw-help-field-hint\" title=\"click to
expand\">" . wfMessage( 'config-help' )->escaped() .
"</span>\n" .
"<span class=\"mw-help-field-data\">" . $html .
"</span>\n" .
"</div>\n";
@@ -1068,14 +1068,9 @@
* @return String Html for download link
*/
public function downloadLinkHook( $text, $attribs, $parser ) {
- $img = Html::element( 'img', array(
- 'src' => '../skins/common/images/download-32.png',
- 'width' => '32',
- 'height' => '32',
- ) );
$anchor = Html::rawElement( 'a',
array( 'href' => $this->getURL( array( 'localsettings'
=> 1 ) ) ),
- $img . ' ' . wfMessage( 'config-download-localsettings'
)->parse() );
+ wfMessage( 'config-download-localsettings' )->parse() );
return Html::rawElement( 'div', array( 'class' =>
'config-download-link' ), $anchor );
}
diff --git a/skins/common/config.css b/skins/common/config.css
index 39206c3..70af84c 100644
--- a/skins/common/config.css
+++ b/skins/common/config.css
@@ -135,8 +135,15 @@
.config-download-link {
font-size: 1.8em;
margin-left: 2em;
+ line-height: 2em;
}
+.config-download-link a {
+ padding-left: 1.8em;
+ background: url("images/download-32.png") no-repeat left;
+}
+
+
#config-live-log {
margin-right: 18em;
}
--
To view, visit https://gerrit.wikimedia.org/r/62157
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iacf5ed57d983a21d87467c848823607032901cec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Waldir <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
