jenkins-bot has submitted this change and it was merged.
Change subject: Remove conditional for X-CS and X-Subdomain check for Vary:.
......................................................................
Remove conditional for X-CS and X-Subdomain check for Vary:.
* X-CS and X-Subdomain should be added to Vary: header for 301s,
keeping in the spirit of idempotent URLs.
Change-Id: Ic830fe37f4ef1372bff0a7d6ac8cb41ff79339cd
---
M includes/MobileFrontend.hooks.php
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Dr0ptp4kt: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index 2c31e24..8956f6a 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -193,10 +193,8 @@
// Bug 43123: force mobile URLs only for local redirects
if ( MobileContext::isLocalUrl( $redirect ) ) {
- if ( isset( $_SERVER['HTTP_X_SUBDOMAIN'] ) && isset(
$_SERVER['HTTP_X_CS'] ) ) {
- $out->addVaryHeader( 'X-Subdomain');
- $out->addVaryHeader( 'X-CS' );
- }
+ $out->addVaryHeader( 'X-Subdomain');
+ $out->addVaryHeader( 'X-CS' );
$redirect = $context->getMobileUrl( $redirect );
}
--
To view, visit https://gerrit.wikimedia.org/r/62182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic830fe37f4ef1372bff0a7d6ac8cb41ff79339cd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: production
Gerrit-Owner: Dr0ptp4kt <[email protected]>
Gerrit-Reviewer: Dr0ptp4kt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
