JGonera has submitted this change and it was merged.
Change subject: nearby.js: Promise fail(), not error()
......................................................................
nearby.js: Promise fail(), not error()
This always gets me. Make sure we bind the function correctly so it
runs on an error
Change-Id: I600446357db49042362488239b2511a13d7bb477
---
M javascripts/specials/nearby.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
JGonera: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/javascripts/specials/nearby.js b/javascripts/specials/nearby.js
index de8af5a..abd4a81 100644
--- a/javascripts/specials/nearby.js
+++ b/javascripts/specials/nearby.js
@@ -140,7 +140,7 @@
text( mw.message(
'mobile-frontend-nearby-noresults' ).plain() ).
appendTo( $content );
}
- } ).error( function() {
+ } ).fail( function() {
$( '#mw-mf-nearby' ).addClass( 'alert error content'
).text( mw.message( 'mobile-frontend-nearby-error' ) );
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/61570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I600446357db49042362488239b2511a13d7bb477
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
