Aklapper has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62220
Change subject: Weekly Bugzilla Report mail: Fix wrong SQL query on bug
resolutions
......................................................................
Weekly Bugzilla Report mail: Fix wrong SQL query on bug resolutions
No, this query really didn't do what it was supposed to. The new one
at least works fine in my local MySQL shell, but testing it again
with the PHP script on the server wouldn't be a bad idea.
Bug: 48072
Change-Id: If088ab6a7ebc26e793f5fb3991d4446a0c5e05f2
---
M templates/misc/bugzilla_report.php
1 file changed, 10 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/20/62220/1
diff --git a/templates/misc/bugzilla_report.php
b/templates/misc/bugzilla_report.php
index 49ce0a0..e8b1112 100755
--- a/templates/misc/bugzilla_report.php
+++ b/templates/misc/bugzilla_report.php
@@ -80,23 +80,27 @@
5;
END;
}
-/* TODO: Check if this really refers to resolution setting, and not to random
changes in last week plus current resolution X */
function getBugResolutions($begin_date, $end_date, $resolution) {
$resolution = mysql_real_escape_string($resolution);
$resolution = "'$resolution'";
return <<<END
SELECT
- count(*)
+ count (distinct bugs.bug_id)
FROM
- bugs
+ bugs, bugs_activity
WHERE
- resolution = $resolution
- and delta_ts
+ bugs.resolution = "$resolution"
+AND
+ bugs_activity.added = "$resolution"
+AND
+ bugs_activity.bug_when
BETWEEN
"$begin_date"
- and
+AND
"$end_date"
+AND
+ bugs.bug_id = bugs_activity.bug_id;
END;
}
--
To view, visit https://gerrit.wikimedia.org/r/62220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If088ab6a7ebc26e793f5fb3991d4446a0c5e05f2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Aklapper <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
