Karim.rayani has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62231
Change subject: Feature: Commons Media of the Day
......................................................................
Feature: Commons Media of the Day
Worked on the Incomplete test case for Common Media of the Day. Made some
changes locally and got this test case working. Test on Firefox, to be tested
on other browsers
Change-Id: I71bd4144b0fcb4b0db8c063b494f319144aeba58
---
M features/step_definitions/commons_media_play_steps.rb
M features/support/pages/commons_main_page.rb
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests
refs/changes/31/62231/1
diff --git a/features/step_definitions/commons_media_play_steps.rb
b/features/step_definitions/commons_media_play_steps.rb
index ff60e20..c698b9e 100644
--- a/features/step_definitions/commons_media_play_steps.rb
+++ b/features/step_definitions/commons_media_play_steps.rb
@@ -4,11 +4,11 @@
When /^I click Menu on Media of the Day$/ do
on(CommonsMainPage) do |page|
- page.player_element.hover
- page.menu
+ page.player_element.when_present(15).hover
+ page.menu_element.fire_event('onclick')
end
end
Then /^a link to the media file appears$/ do
- on(CommonsMainPage).credits_box.text.should_match
Regexp.escape('//commons.wikimedia.org/w/index.php?title=')
+ on(CommonsMainPage).credits_box_element.when_present(15).html.should match
Regexp.escape('//commons.wikimedia.org/w/index.php?title=')
end
diff --git a/features/support/pages/commons_main_page.rb
b/features/support/pages/commons_main_page.rb
index e9c6e6c..90fa2c5 100644
--- a/features/support/pages/commons_main_page.rb
+++ b/features/support/pages/commons_main_page.rb
@@ -8,5 +8,5 @@
span(:menu, text: 'Menu')
div(:credits_box, class: 'creditline')
- video(:player, id: 'pid_mwe_player_0')
+ div(:player, id: 'mwe_player_0')
end
--
To view, visit https://gerrit.wikimedia.org/r/62231
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71bd4144b0fcb4b0db8c063b494f319144aeba58
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Karim.rayani <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
