Amire80 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62235
Change subject: Apply dir and lang to the target language selector trigger
......................................................................
Apply dir and lang to the target language selector trigger
Change-Id: Ib830a5856ec41ea795fa738e5eb58c40c09ce7d7
---
M resources/css/ext.translate.groupselector.css
M resources/js/ext.translate.special.translate.js
M specials/SpecialTranslate.php
3 files changed, 19 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/35/62235/1
diff --git a/resources/css/ext.translate.groupselector.css
b/resources/css/ext.translate.groupselector.css
index bec55a1..8656d7b 100644
--- a/resources/css/ext.translate.groupselector.css
+++ b/resources/css/ext.translate.groupselector.css
@@ -48,7 +48,7 @@
padding-top: 1.25em;
}
-.ext-translate-language-selector .uls:after {
+.ext-translate-language-selector:after {
margin-left: 4px;
border-left: 4px solid transparent;
border-right: 4px solid transparent;
diff --git a/resources/js/ext.translate.special.translate.js
b/resources/js/ext.translate.special.translate.js
index 76ec11d..de83556 100644
--- a/resources/js/ext.translate.special.translate.js
+++ b/resources/js/ext.translate.special.translate.js
@@ -102,18 +102,26 @@
},
changeLanguage: function ( language ) {
- var changes = {
- language: language
- };
+ var changes, targetDir;
if ( !checkDirty() ) {
return;
}
- $( '.ext-translate-language-selector > .uls' ).text(
$.uls.data.getAutonym( language ) );
+ changes = {
+ language: language
+ };
+
+ targetDir = $.uls.data.getDir( language );
+ $( '.ext-translate-language-selector > .uls' )
+ .text( $.uls.data.getAutonym( language ) )
+ .attr( {
+ lang: language,
+ dir: targetDir
+ } );
$( '.tux-messagelist' ).data( {
targetlangcode: language,
- targetlangdir: $.uls.data.getDir( language )
+ targetlangdir: targetDir
} );
mw.translate.changeUrl( changes );
diff --git a/specials/SpecialTranslate.php b/specials/SpecialTranslate.php
index 1a81b85..463e531 100644
--- a/specials/SpecialTranslate.php
+++ b/specials/SpecialTranslate.php
@@ -557,7 +557,11 @@
) .
' ' . // nbsp
Html::element( 'span',
- array( 'class' => 'uls' ),
+ array(
+ 'class' => 'uls',
+ 'lang' =>
$this->options['language'],
+ 'dir' => Language::factory(
$this->options['language'] )->getDir(),
+ ),
Language::fetchLanguageName(
$this->options['language'] )
)
);
--
To view, visit https://gerrit.wikimedia.org/r/62235
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib830a5856ec41ea795fa738e5eb58c40c09ce7d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
