Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/62414


Change subject: Alpha table module: Blacklist tables with class metadata or 
navbox
......................................................................

Alpha table module: Blacklist tables with class metadata or navbox

These don't look good collapsed

Change-Id: I5430be3db7b9ed83d691aceca25d72bedb73df74
---
M javascripts/modules/mf-tables.js
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/14/62414/1

diff --git a/javascripts/modules/mf-tables.js b/javascripts/modules/mf-tables.js
index be57d7f..ee202a9 100644
--- a/javascripts/modules/mf-tables.js
+++ b/javascripts/modules/mf-tables.js
@@ -3,6 +3,10 @@
 ( function() {
        var STEP_SIZE = 150;
 
+       function isBlacklisted( $table ) {
+               return $table.hasClass( 'metadata' ) || $table.hasClass( 
'navbox' );
+       }
+
        function collapseTables( $container ) {
                var nav = M.require( 'navigation' ),
                        $tables = $container ? $container.find( 'table' ) : $( 
'table' );
@@ -15,7 +19,7 @@
                                colspan, $tr, maxHeight, $td,
                                $container = $( '<div class="tableContent">' );
 
-                       if ( $t.parents( 'table' ).length === 0 && $tc.length > 
0 ) {
+                       if ( $t.parents( 'table' ).length === 0 && $tc.length > 
0 && !isBlacklisted( $t ) ) {
                                $block = $t.parents( '.content_block' );
                                if ( $block ) {
                                        $t.addClass( 'expando' ).css( { height: 
STEP_SIZE } );

-- 
To view, visit https://gerrit.wikimedia.org/r/62414
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5430be3db7b9ed83d691aceca25d72bedb73df74
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to