Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62435
Change subject: (bug 47733) Word count is wrong, does not recognize non-ASCII
characters
......................................................................
(bug 47733) Word count is wrong, does not recognize non-ASCII characters
str_word_count does not handle multibyte characters so will fail miserably in
some foreign languages. It's an utterly useless metric anyway.
Change-Id: I84a72f3894fb19d2834719ebf253e33f2d436d8e
---
M ArticleFeedbackv5.i18n.php
M ArticleFeedbackv5.render.php
2 files changed, 4 insertions(+), 15 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5
refs/changes/35/62435/1
diff --git a/ArticleFeedbackv5.i18n.php b/ArticleFeedbackv5.i18n.php
index ee96d9a..22d910d 100644
--- a/ArticleFeedbackv5.i18n.php
+++ b/ArticleFeedbackv5.i18n.php
@@ -305,8 +305,7 @@
'articlefeedbackv5-permalink-info-revision-link' => 'See old version',
'articlefeedbackv5-permalink-info-posted' => 'Posted on $1 at $2',
'articlefeedbackv5-permalink-info-stats-title-length' => 'Length',
- 'articlefeedbackv5-permalink-info-length-words' => '{{PLURAL:$1|$1
word|$1 words}}',
- 'articlefeedbackv5-permalink-info-length-characters' =>
'({{PLURAL:$1|$1 character|$1 characters}})',
+ 'articlefeedbackv5-permalink-info-length-characters' => '{{PLURAL:$1|$1
character|$1 characters}}',
'articlefeedbackv5-permalink-info-stats-title-scores' => 'Scores',
'articlefeedbackv5-permalink-info-stats-subtitle-relevance' =>
'Relevance:',
'articlefeedbackv5-permalink-info-stats-subtitle-helpfulness' =>
'Helpfulness:',
@@ -1217,7 +1216,6 @@
'articlefeedbackv5-permalink-info-posted' => 'Permalink info block,
post date line: $1 is the date; $2 is the time',
'articlefeedbackv5-permalink-info-stats-title-length' => 'Permalink
info block, title for the comment length information.
{{Identical|Length}}',
- 'articlefeedbackv5-permalink-info-length-words' => 'Permalink info
block, comment length: $1 is the number of words',
'articlefeedbackv5-permalink-info-length-characters' => 'Permalink info
block, comment length: $1 is the number of characters',
'articlefeedbackv5-permalink-info-stats-title-scores' => 'Permalink
info block, title for the feedback scoring information',
'articlefeedbackv5-permalink-info-stats-subtitle-relevance' =>
'Permalink info block, subtitle for the relevance score within the feedback
scoring information',
diff --git a/ArticleFeedbackv5.render.php b/ArticleFeedbackv5.render.php
index 55e7a12..d2cbf4c 100644
--- a/ArticleFeedbackv5.render.php
+++ b/ArticleFeedbackv5.render.php
@@ -1141,18 +1141,9 @@
'dd',
array(),
wfMessage(
-
'articlefeedbackv5-permalink-info-length-words',
- str_word_count(
$record->aft_comment )
- )->escaped() .
- ' ' .
- Html::rawElement(
- 'span',
- array(),
- wfMessage(
-
'articlefeedbackv5-permalink-info-length-characters',
- strlen(
$record->aft_comment )
- )->escaped()
- )
+
'articlefeedbackv5-permalink-info-length-characters',
+ mb_strlen( $record->aft_comment
)
+ )->escaped()
);
}
--
To view, visit https://gerrit.wikimedia.org/r/62435
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84a72f3894fb19d2834719ebf253e33f2d436d8e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
