Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/62440


Change subject: Update code to match MWSearch updates, fixing fatal
......................................................................

Update code to match MWSearch updates, fixing fatal

PHP Fatal error:  Call to undefined method Status::next() in 
/usr/local/apache/common-local/php-1.22wmf3/extensions/ProofreadPage/SpecialProofreadPages.php
 on line 83

Change-Id: I0b6a49ae8008351ff0c86110009766a36b8dd778
---
M SpecialProofreadPages.php
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/40/62440/1

diff --git a/SpecialProofreadPages.php b/SpecialProofreadPages.php
index 4143a06..0df6cd6 100644
--- a/SpecialProofreadPages.php
+++ b/SpecialProofreadPages.php
@@ -75,7 +75,9 @@
                                $searchEngine->setNamespaces( array( 
$indexNamespaceId ) );
                                $searchEngine->showRedirects = false;
                                $textMatches = $searchEngine->searchText( 
$this->searchTerm );
-                               if( $textMatches === null) {
+                               if( !( $textMatches instanceof SearchResultSet 
) ) {
+                                       // TODO: $searchEngine->searchText() 
can return status objects
+                                       // Might want to extract some 
information from them
                                        global $wgOut;
                                        $wgOut->showErrorPage( 
'proofreadpage_specialpage_searcherror', 
'proofreadpage_specialpage_searcherrortext' );
                                } else {

-- 
To view, visit https://gerrit.wikimedia.org/r/62440
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b6a49ae8008351ff0c86110009766a36b8dd778
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to