coren has submitted this change and it was merged.
Change subject: tcpircbot: subscribe to (rather than require) config
......................................................................
tcpircbot: subscribe to (rather than require) config
Requiring the config means the bot doesn't get restarted if the configuration
changes, as did in fact happen with change Ib33d3cc66: the bot was not
restarted by the Puppet run that made the configuration change.
Change-Id: Icd89287f06c289c34ea71940e22447999404245b
---
M modules/tcpircbot/manifests/instance.pp
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
coren: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/tcpircbot/manifests/instance.pp
b/modules/tcpircbot/manifests/instance.pp
index 22f06c4..8fe9b6f 100644
--- a/modules/tcpircbot/manifests/instance.pp
+++ b/modules/tcpircbot/manifests/instance.pp
@@ -82,12 +82,12 @@
}
service { "tcpircbot-${title}":
- ensure => running,
- provider => 'upstart',
- require => [
+ ensure => running,
+ provider => 'upstart',
+ subscribe => File["/etc/init/tcpircbot-${title}.conf"],
+ require => [
Package['python-irclib'],
File["${tcpircbot::dir}/${title}.json"],
- File["/etc/init/tcpircbot-${title}.conf"]
],
}
}
--
To view, visit https://gerrit.wikimedia.org/r/62214
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd89287f06c289c34ea71940e22447999404245b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: coren <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
