Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62584
Change subject: Remove pointless checks that obstruct library usage
......................................................................
Remove pointless checks that obstruct library usage
Change-Id: I1695b2f64c3aff2688f806c5fc20416fb688bd2f
---
M DataTypes/DataTypes.php
M DataValues/DataValues.mw.php
M DataValues/DataValues.php
M ValueFormatters/ValueFormatters.php
M ValueParsers/ValueParsers.php
M ValueValidators/ValueValidators.php
M ValueView/ValueView.php
7 files changed, 0 insertions(+), 55 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues
refs/changes/84/62584/1
diff --git a/DataTypes/DataTypes.php b/DataTypes/DataTypes.php
index 2ebcd85..fe5fda2 100644
--- a/DataTypes/DataTypes.php
+++ b/DataTypes/DataTypes.php
@@ -46,14 +46,6 @@
namespace DataTypes;
-if ( !defined( 'DATAVALUES' ) && !defined( 'MEDIAWIKI' ) ) {
- die( 'Not an entry point.' );
-}
-
-if ( !defined( 'DATAVALUES' ) ) {
- define( 'DATAVALUES', true );
-}
-
define( 'DataTypes_VERSION', '0.1 alpha' );
global $wgDataTypes;
diff --git a/DataValues/DataValues.mw.php b/DataValues/DataValues.mw.php
index dc461a8..f83caf4 100644
--- a/DataValues/DataValues.mw.php
+++ b/DataValues/DataValues.mw.php
@@ -27,14 +27,6 @@
* @author Jeroen De Dauw < [email protected] >
*/
-if ( !defined( 'MEDIAWIKI' ) ) {
- die( 'Not an entry point.' );
-}
-
-if ( !defined( 'DATAVALUES' ) ) {
- define( 'DATAVALUES', true );
-}
-
global $wgExtensionCredits, $wgExtensionMessagesFiles, $wgAutoloadClasses,
$wgHooks, $wgResourceModules;
$wgExtensionCredits['datavalues'][] = array(
diff --git a/DataValues/DataValues.php b/DataValues/DataValues.php
index 9263b00..63279df 100644
--- a/DataValues/DataValues.php
+++ b/DataValues/DataValues.php
@@ -44,14 +44,6 @@
* @ingroup DataValues
*/
-if ( !defined( 'DATAVALUES' ) && !defined( 'MEDIAWIKI' ) ) {
- die( 'Not an entry point.' );
-}
-
-if ( !defined( 'DATAVALUES' ) ) {
- define( 'DATAVALUES', true );
-}
-
define( 'DataValues_VERSION', '0.1 alpha' );
if ( defined( 'MEDIAWIKI' ) ) {
diff --git a/ValueFormatters/ValueFormatters.php
b/ValueFormatters/ValueFormatters.php
index 5eb394f..9393962 100644
--- a/ValueFormatters/ValueFormatters.php
+++ b/ValueFormatters/ValueFormatters.php
@@ -45,14 +45,6 @@
* @ingroup Test
*/
-if ( !defined( 'DATAVALUES' ) && !defined( 'MEDIAWIKI' ) ) {
- die( 'Not an entry point.' );
-}
-
-if ( !defined( 'DATAVALUES' ) ) {
- define( 'DATAVALUES', true );
-}
-
define( 'ValueFormatters_VERSION', '0.1 alpha' );
global $wgValueFormatters;
diff --git a/ValueParsers/ValueParsers.php b/ValueParsers/ValueParsers.php
index ba2ce21..689ebb0 100644
--- a/ValueParsers/ValueParsers.php
+++ b/ValueParsers/ValueParsers.php
@@ -45,14 +45,6 @@
* @ingroup Test
*/
-if ( !defined( 'DATAVALUES' ) && !defined( 'MEDIAWIKI' ) ) {
- die( 'Not an entry point.' );
-}
-
-if ( !defined( 'DATAVALUES' ) ) {
- define( 'DATAVALUES', true );
-}
-
define( 'ValueParsers_VERSION', '0.1 alpha' );
global $wgValueParsers;
diff --git a/ValueValidators/ValueValidators.php
b/ValueValidators/ValueValidators.php
index e726238..3ead83c 100644
--- a/ValueValidators/ValueValidators.php
+++ b/ValueValidators/ValueValidators.php
@@ -45,14 +45,6 @@
* @ingroup Test
*/
-if ( !defined( 'DATAVALUES' ) && !defined( 'MEDIAWIKI' ) ) {
- die( 'Not an entry point.' );
-}
-
-if ( !defined( 'DATAVALUES' ) ) {
- define( 'DATAVALUES', true );
-}
-
define( 'ValueValidators_VERSION', '0.1 alpha' );
global $wgValueValidators;
diff --git a/ValueView/ValueView.php b/ValueView/ValueView.php
index e2ada22..04f04ff 100644
--- a/ValueView/ValueView.php
+++ b/ValueView/ValueView.php
@@ -31,13 +31,6 @@
* @author Daniel Werner < [email protected] >
*/
-if ( !defined( 'DATAVALUES' ) && !defined( 'MEDIAWIKI' ) ) {
- die( 'Not an entry point.' );
-}
-
-if ( !defined( 'DATAVALUES' ) ) {
- define( 'DATAVALUES', true );
-}
define( 'ValueView_VERSION', '0.1 alpha' );
--
To view, visit https://gerrit.wikimedia.org/r/62584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1695b2f64c3aff2688f806c5fc20416fb688bd2f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
