[MediaWiki-commits] [Gerrit] Fix incomplete tests - change (mediawiki...Wikibase)

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/62609


Change subject: Fix incomplete tests
......................................................................

Fix incomplete tests

Change-Id: If46eac0e804ad10dc74cc120125b10510b4770da
---
M repo/tests/phpunit/includes/api/EditEntityTest.php
M repo/tests/phpunit/includes/api/GetEntitiesTest.php
M repo/tests/phpunit/includes/api/LinkTitlesTest.php
3 files changed, 3 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/09/62609/1

diff --git a/repo/tests/phpunit/includes/api/EditEntityTest.php 
b/repo/tests/phpunit/includes/api/EditEntityTest.php
index a6ee2b1..03cfd53 100644
--- a/repo/tests/phpunit/includes/api/EditEntityTest.php
+++ b/repo/tests/phpunit/includes/api/EditEntityTest.php
@@ -677,17 +677,4 @@
                }
        }
 
-
-       function testProtectedItem() { //TODO
-               $this->markTestIncomplete();
-       }
-
-       function testBlockedUser() { //TODO
-               $this->markTestIncomplete();
-       }
-
-       function testEditPermission() { //TODO
-               $this->markTestIncomplete();
-       }
-
 }
diff --git a/repo/tests/phpunit/includes/api/GetEntitiesTest.php 
b/repo/tests/phpunit/includes/api/GetEntitiesTest.php
index e93749c..fa72257 100644
--- a/repo/tests/phpunit/includes/api/GetEntitiesTest.php
+++ b/repo/tests/phpunit/includes/api/GetEntitiesTest.php
@@ -206,6 +206,7 @@
                        $this->fail( "expected request to fail" );
                } catch ( \UsageException $ex ) {
                        // ok
+                       $this->assertTrue( true );
                }
        }
 
diff --git a/repo/tests/phpunit/includes/api/LinkTitlesTest.php 
b/repo/tests/phpunit/includes/api/LinkTitlesTest.php
index b842ae4..7cdfb86 100644
--- a/repo/tests/phpunit/includes/api/LinkTitlesTest.php
+++ b/repo/tests/phpunit/includes/api/LinkTitlesTest.php
@@ -187,6 +187,8 @@
                if ( $handle ) {
                        $this->resetItem( $handle );
                }
+
+               $this->assertTrue( true );
        }
 
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/62609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If46eac0e804ad10dc74cc120125b10510b4770da
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits