Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/62644


Change subject: Remove empty test
......................................................................

Remove empty test

Change-Id: I88c1a751c8aeda8038a45a5fffc9b5d3898a64f0
---
M lib/WikibaseLib.hooks.php
D lib/tests/phpunit/DataTypesTest.php
2 files changed, 0 insertions(+), 56 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/44/62644/1

diff --git a/lib/WikibaseLib.hooks.php b/lib/WikibaseLib.hooks.php
index 2bb2884..8af3a8c 100644
--- a/lib/WikibaseLib.hooks.php
+++ b/lib/WikibaseLib.hooks.php
@@ -69,7 +69,6 @@
                        'ByPropertyIdArray',
                        'ChangesTable',
                        'ClaimDifference',
-                       'DataTypes',
                        'ReferencedEntitiesFinder',
                        'EntityRetrievingDataTypeLookup',
                        'InMemoryDataTypeLookup',
diff --git a/lib/tests/phpunit/DataTypesTest.php 
b/lib/tests/phpunit/DataTypesTest.php
deleted file mode 100644
index 978fe10..0000000
--- a/lib/tests/phpunit/DataTypesTest.php
+++ /dev/null
@@ -1,55 +0,0 @@
-<?php
-
-namespace Wikibase\Lib\Test;
-
-/**
- * Tests for the data types defined in WikibaseLib.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
- * @file
- * @since 0.4
- *
- * @ingroup WikibaseLib
- * @ingroup Test
- *
- * @group Wikibase
- * @group WikibaseLib
- *
- * @licence GNU GPL v2+
- * @author Jeroen De Dauw < [email protected] >
- */
-class DataTypesTest extends \MediaWikiTestCase {
-
-       protected function getFactory() {
-               $registry = new \Wikibase\LibRegistry( 
\Wikibase\Settings::singleton() );
-               return $registry->getDataTypeFactory();
-       }
-
-       public function testItemDataType() {
-               $dataType = $this->getFactory()->getType( 'wikibase-item' );
-
-               $parsers = $dataType->getParsers();
-               $parser = $parsers[0];
-
-               $expected = new \Wikibase\EntityId( 
\Wikibase\Item::ENTITY_TYPE, 42 );
-
-               $result = $parser->parse( $expected->getPrefixedId() );
-
-               $this->assertTrue( $expected->equals( $result ) );
-       }
-
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/62644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88c1a751c8aeda8038a45a5fffc9b5d3898a64f0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to