Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62660
Change subject: Code hygiene: Move drawer css into separate file
......................................................................
Code hygiene: Move drawer css into separate file
Change-Id: Id63ff9d8dd66be9e27848c0d73e45d931865d3c5
---
M MobileFrontend.php
A less/common/drawer.less
M less/common/mf-navigation.less
A stylesheets/common/drawer.css
M stylesheets/common/mf-navigation.css
5 files changed, 46 insertions(+), 44 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/60/62660/1
diff --git a/MobileFrontend.php b/MobileFrontend.php
index dfb102d..a35682c 100644
--- a/MobileFrontend.php
+++ b/MobileFrontend.php
@@ -235,6 +235,7 @@
// FIXME: move to module mobile.stable.styles for some reason
it breaks RTL when in that module
'stylesheets/common/mf-navigation.css',
'stylesheets/common/overlays.css',
+ 'stylesheets/common/drawer.css',
'stylesheets/common/mf-hacks.css',
),
'position' => 'top',
diff --git a/less/common/drawer.less b/less/common/drawer.less
new file mode 100644
index 0000000..9af0ce5
--- /dev/null
+++ b/less/common/drawer.less
@@ -0,0 +1,25 @@
+@import "../mf-mixins.less";
+
+.drawer {
+ text-align: center;
+ padding: 0 0 1em;
+
+ a.close {
+ padding: 0 0 1.2em;
+ display: block;
+ overflow: hidden;
+ text-indent: -9999px;
+ width: 100%;
+ height: 16px;
+ background: url(../modules/images/show.png) 50% 8px no-repeat;
+ }
+
+ a.button {
+ display: block;
+ margin: 1em @searchBarPaddingLeft 1em @searchBarPaddingRight;
+ }
+
+ a.signup {
+ display: block;
+ }
+}
diff --git a/less/common/mf-navigation.less b/less/common/mf-navigation.less
index 7afaf74..072bfbb 100644
--- a/less/common/mf-navigation.less
+++ b/less/common/mf-navigation.less
@@ -196,27 +196,3 @@
display: none;
}
}
-
-.drawer {
- text-align: center;
- padding: 0 0 1em;
-
- a.close {
- padding: 0 0 1.2em;
- display: block;
- overflow: hidden;
- text-indent: -9999px;
- width: 100%;
- height: 16px;
- background: url(../modules/images/show.png) 50% 8px no-repeat;
- }
-
- a.button {
- display: block;
- margin: 1em @searchBarPaddingLeft 1em @searchBarPaddingRight;
- }
-
- a.signup {
- display: block;
- }
-}
diff --git a/stylesheets/common/drawer.css b/stylesheets/common/drawer.css
new file mode 100644
index 0000000..08d753a
--- /dev/null
+++ b/stylesheets/common/drawer.css
@@ -0,0 +1,20 @@
+.drawer {
+ text-align: center;
+ padding: 0 0 1em;
+}
+.drawer a.close {
+ padding: 0 0 1.2em;
+ display: block;
+ overflow: hidden;
+ text-indent: -9999px;
+ width: 100%;
+ height: 16px;
+ background: url(../modules/images/show.png) 50% 8px no-repeat;
+}
+.drawer a.button {
+ display: block;
+ margin: 1em 40px 1em 40px;
+}
+.drawer a.signup {
+ display: block;
+}
diff --git a/stylesheets/common/mf-navigation.css
b/stylesheets/common/mf-navigation.css
index 7f1a886..b849cb4 100644
--- a/stylesheets/common/mf-navigation.css
+++ b/stylesheets/common/mf-navigation.css
@@ -147,23 +147,3 @@
.full-screen-search #mw-mf-menu-page {
display: none;
}
-.drawer {
- text-align: center;
- padding: 0 0 1em;
-}
-.drawer a.close {
- padding: 0 0 1.2em;
- display: block;
- overflow: hidden;
- text-indent: -9999px;
- width: 100%;
- height: 16px;
- background: url(../modules/images/show.png) 50% 8px no-repeat;
-}
-.drawer a.button {
- display: block;
- margin: 1em 40px 1em 40px;
-}
-.drawer a.signup {
- display: block;
-}
--
To view, visit https://gerrit.wikimedia.org/r/62660
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id63ff9d8dd66be9e27848c0d73e45d931865d3c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
