JGonera has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/62664


Change subject: Add debug argument (-d or --debug-folder)
......................................................................

Add debug argument (-d or --debug-folder)

When given a directory, it writes the generated SQL that can be used
for debugging purposes.

Change-Id: I1a7a88bb7266cbc6d67a0da50e40d5a15361e2cf
---
M generate.py
1 file changed, 9 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/limn-mobile-data 
refs/changes/64/62664/1

diff --git a/generate.py b/generate.py
index 7ad1600..1cc929a 100644
--- a/generate.py
+++ b/generate.py
@@ -15,9 +15,10 @@
 class DataGenerator(object):
     """Executes queries and generates CSV reports based on YAML configs."""
 
-    def __init__(self, folder, config_override=None):
+    def __init__(self, folder, debug_folder=None, config_override=None):
         """Reads configuration 'config.yaml' in `folder_path`."""
         self.folder = folder
+        self.debug_folder = debug_folder
         self.config = {}
         self.connections = {}
         config_main = os.path.join(folder, 'config.yaml')
@@ -67,6 +68,12 @@
         """
         with io.open(file_name, encoding='utf-8') as f:
             sql = self.render(f.read())
+
+        if self.debug_folder:
+            debug_filename = os.path.join(self.debug_folder, 
os.path.basename(file_name))
+            with open(debug_filename, 'wb') as debug_file:
+                debug_file.write(sql)
+
         conn = self.get_connection(db_name)
         cursor = conn.cursor()
         try:
@@ -139,6 +146,7 @@
     parser = argparse.ArgumentParser(description='Generate data for the mobile 
dashboard.')
     parser.add_argument('folder', help='folder with config.yaml and *.sql 
files')
     parser.add_argument('-c', '--config-override', help='config.yaml override')
+    parser.add_argument('-d', '--debug-folder', help='save generated SQL in a 
given folder')
     args = parser.parse_args()
 
     dg = DataGenerator(**vars(args))

-- 
To view, visit https://gerrit.wikimedia.org/r/62664
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a7a88bb7266cbc6d67a0da50e40d5a15361e2cf
Gerrit-PatchSet: 1
Gerrit-Project: analytics/limn-mobile-data
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to