jenkins-bot has submitted this change and it was merged.
Change subject: mediawiki.user: Use session ID instead of 1-year cross-session
cookies
......................................................................
mediawiki.user: Use session ID instead of 1-year cross-session cookies
No cookies should be assigned for longer than session expiry.
Bug: 44327
Change-Id: If2f096dadb639769d859e1596d84b3ad5775a01d
---
M resources/mediawiki/mediawiki.user.js
1 file changed, 3 insertions(+), 17 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
Parent5446: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/resources/mediawiki/mediawiki.user.js
b/resources/mediawiki/mediawiki.user.js
index e036dc9..9fd2e5e 100644
--- a/resources/mediawiki/mediawiki.user.js
+++ b/resources/mediawiki/mediawiki.user.js
@@ -141,30 +141,16 @@
};
/**
- * Gets the current user's name or a random ID automatically
generated and kept in a cookie.
- *
- * This ID is persistent for anonymous users, staying in their
browser up to 1 year. The
- * expiration time is reset each time the ID is queried, so in
most cases this ID will
- * persist until the browser's cookies are cleared or the user
doesn't visit for 1 year.
+ * Gets the current user's name or the session ID
*
* @return {string} User name or random session ID
*/
this.id = function () {
- var id,
- name = user.getName();
+ var name = user.getName();
if ( name ) {
return name;
}
- id = $.cookie( 'mediaWiki.user.id' );
- if ( typeof id === 'undefined' || id === null ) {
- id = user.generateRandomSessionId();
- }
- // Set cookie if not set, or renew it if already set
- $.cookie( 'mediaWiki.user.id', id, {
- expires: 365,
- path: '/'
- } );
- return id;
+ return user.sessionId();
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/53195
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2f096dadb639769d859e1596d84b3ad5775a01d
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Adamw <[email protected]>
Gerrit-Reviewer: Adamw <[email protected]>
Gerrit-Reviewer: DarTar <[email protected]>
Gerrit-Reviewer: Diederik <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: PleaseStand <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
